Page MenuHomePhabricator

Tasks should have structured way to view all media that had been mentioned, or attached
Closed, ResolvedPublic

Description

Upstream report: https://secure.phabricator.com/T6831

In tasks with many comments, it becomes more difficult to find uploaded assets within tasks. The top structured area of a task could aggregate all uploaded media and mockups.

The proposal, in more detail:

  • It should be possible to add Files to the header of a task, just like Mockups today.
  • Mockups and Files embedded in the task description or a comment (using curly brackets {M...} {F...} would be added to the task header. This behavior is consistent with the possibility of adding projects and users by mentioning them in a specific way.
  • Mentions of Mockups or Files in descriptions or comments (plain M... F... references) would not be added automatically.

Example:

  • Event Timeline

    Jaredzimmerman-WMF raised the priority of this task from to Needs Triage.
    Jaredzimmerman-WMF triaged this task as High priority.
    Jaredzimmerman-WMF updated the task description. (Show Details)
    Jaredzimmerman-WMF changed Security from none to None.
    Qgil lowered the priority of this task from High to Medium.EditedDec 3 2014, 9:58 AM
    Qgil updated the task description. (Show Details)
    Qgil subscribed.

    So what happens when a mock is mentioned in a comment: M2

  • It looks like these problems can be solved with a process that makes the most of the tools we have:

    • Images that will require feedback, iterations, etc. should be mockups. Files are one-off disposable images, i.e. a screenshot.
    • The version control, history, deprecation of old versions, annotations, comments... specific to a mockup go to the mockup. This process is similar to discussing and evolving a patch in code review.
    • Mockups can be added to tasks via "Edit Pholio Mocks". This will list them always in the header of the task, and will show whether they are open or closed.
    • Optionally, you can add a thumbnail of the mockups in the description of the task, which will show the current version.

    @Qgil that doesn't cover instances where a resource like a svg of an icon is added to a task, then later updated, it isn't a mockup, and doesn't require commenting or annotation, requiring pholio mocks for these is a lot of overhead, I don't even want to count the clicks needed to do that.

    I'm identifying this as a regression in functionally for those switching from bugzilla and trello.

    Understood. Can you please point me to examples of Trello tasks and Bugzilla reports that you consider good examples of what we should aim for?

    I still think that a media file it is either important to the discussion at hand or just disposable after being used in a comment. If it is important, it should probably be handled as a mockup. I agree that this takes too many clicks, though.

    What about this proposal to be filed upstream:

    • It should be possible to add Files to the header of a task, just like Mockups today.
    • Mockups and Files embedded in the task description or a comment (using curly brackets {M...} {F...}should be added to the task header. This behavior is consistent with the possibility of adding projects and users by mentioning them in a specific way.
    • Mentions of Mockups or Files in descriptions or comment (plain M... F... references) should not added automatically.
    Aklapper lowered the priority of this task from Medium to Low.Jan 24 2015, 9:56 PM

    The top structured area of a task could aggregate all uploaded media and mockups.

    This is the case already as there is a "Details" box right after the task description, listing any associated "Pholio Mocks".

    Not sure if that resolves this task?

    Aklapper claimed this task.

    No reply, hence assuming it does.