Page MenuHomePhabricator

Gerrit mangles urls containing T123
Closed, DuplicatePublic

Description

Any commentlink regexes that exclusively contain characters valid in a url must use the alternate regex hack we applied to the commit commentlink as well. Things like "bug 123" are fine since a space and can't match a url.


See also

Event Timeline

Krinkle raised the priority of this task from to Medium.
Krinkle updated the task description. (Show Details)
Krinkle added a project: Gerrit.
Krinkle changed Security from none to None.
Krinkle added a subscriber: Krinkle.

Change 177128 had a related patch set uploaded (by Krinkle):
gerrit: Don't match Phabricator identifiers within urls

https://gerrit.wikimedia.org/r/177128

Patch-For-Review