Page MenuHomePhabricator
Create Task
Maniphest T76602

Monobook: Topic titlebar needs better line spacing when the title is longer than one line
Closed, ResolvedPublic
Actions

Description

See attachment.

In Monobook, topic titles that run longer than one line look terrible. We need to add better line spacing for the title.

Trello card: SBKOELrs

Details

Related Gerrit Patches:
mediawiki/extensions/Flow : masterUse unitless line-height for consistent inheritance
mediawiki/extensions/Flow : masterFix bad spacing in topic title on monobook

Related Objects

Event Timeline

• Spage raised the priority of this task from to Medium.Dec 3 2014, 12:22 PM
• Spage added a project: Collaboration-Team-Triage.
gerritbot added a project: Patch-For-Review.Dec 3 2014, 5:24 PM

Change 177165 had a related patch set uploaded (by EBernhardson):
Fix bad spacing in topic title on monobook

https://gerrit.wikimedia.org/r/177165

Patch-For-Review

EBernhardson claimed this task.Dec 5 2014, 7:54 PM
EBernhardson set Security to None.
gerritbot added a comment.Dec 8 2014, 3:36 PM

Change 177165 merged by jenkins-bot:
Fix bad spacing in topic title on monobook

https://gerrit.wikimedia.org/r/177165

DannyH added a subscriber: DannyH.Dec 16 2014, 6:00 PM

This isn't working, on ee-flow or mediawiki. Is it up anywhere?

gerritbot added a comment.Dec 16 2014, 6:20 PM

Change 180217 had a related patch set uploaded (by EBernhardson):
Use unitless line-height for consistent inheritance

https://gerrit.wikimedia.org/r/180217

Patch-For-Review

EBernhardson added a comment.Dec 16 2014, 6:20 PM

We fixed it in a few places, but it still triggers under one condition that you seem to have hit :) One-line patch above should finish fixing it.

• Spage removed EBernhardson as the assignee of this task.Jan 12 2015, 7:20 PM
gerritbot added a comment.Jan 13 2015, 3:34 PM

Change 180217 merged by jenkins-bot:
Use unitless line-height for consistent inheritance

https://gerrit.wikimedia.org/r/180217

Quiddity closed this task as Resolved.Jan 28 2015, 7:39 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL