Page MenuHomePhabricator
Create Task
Maniphest T76602

Monobook: Topic titlebar needs better line spacing when the title is longer than one line
Closed, ResolvedPublic
Actions

Description

See attachment.

In Monobook, topic titles that run longer than one line look terrible. We need to add better line spacing for the title.

Trello card: SBKOELrs

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Flowmaster+1 -1Use unitless line-height for consistent inheritance
mediawiki/extensions/Flowmaster+9 -11Fix bad spacing in topic title on monobook
Customize query in gerrit

Related Objects

Event Timeline

• Spage raised the priority of this task from to Medium.Dec 3 2014, 12:22 PM
• Spage added a project: Collaboration-Team-Triage.
• Spage moved this task from Untriaged to Code Review on the Collaboration-Team-Triage board.Dec 3 2014, 12:23 PM
gerritbot added a project: Patch-For-Review.Dec 3 2014, 5:24 PM

Change 177165 had a related patch set uploaded (by EBernhardson):
Fix bad spacing in topic title on monobook

https://gerrit.wikimedia.org/r/177165

Patch-For-Review

EBernhardson claimed this task.Dec 5 2014, 7:54 PM
EBernhardson set Security to None.
gerritbot added a comment.Dec 8 2014, 3:36 PM

Change 177165 merged by jenkins-bot:
Fix bad spacing in topic title on monobook

https://gerrit.wikimedia.org/r/177165

matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Triage board.Dec 8 2014, 6:33 PM
EBernhardson mentioned this in rEFLW56ba5cbcbe03: Fix bad spacing in topic title on monobook.Dec 10 2014, 8:30 PM
DannyH added a subscriber: DannyH.Dec 16 2014, 6:00 PM

This isn't working, on ee-flow or mediawiki. Is it up anywhere?

eeflow_four_score.jpg (730×1 px, 380 KB)

DannyH moved this task from Product Review to Blocked with questions on the Collaboration-Team-Triage board.Dec 16 2014, 6:00 PM
gerritbot added a comment.Dec 16 2014, 6:20 PM

Change 180217 had a related patch set uploaded (by EBernhardson):
Use unitless line-height for consistent inheritance

https://gerrit.wikimedia.org/r/180217

Patch-For-Review

EBernhardson added a comment.Dec 16 2014, 6:20 PM

We fixed it in a few places, but it still triggers under one condition that you seem to have hit :) One-line patch above should finish fixing it.

EBernhardson moved this task from Blocked with questions to Code Review on the Collaboration-Team-Triage board.Dec 16 2014, 11:48 PM
• Spage edited projects, added Collaboration-Team-Sprint-M-2014-12-17; removed Collaboration-Team-Triage.Dec 18 2014, 6:18 PM
• Spage added a project: Collaboration-Team-Triage.Dec 19 2014, 3:36 AM
• Spage moved this task from Code Review to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.Dec 19 2014, 3:45 AM
• Spage removed EBernhardson as the assignee of this task.Jan 12 2015, 7:20 PM
DannyH moved this task from Sprint O (ends Jan 27) to Code Review on the Collaboration-Team-Triage board.Jan 12 2015, 7:22 PM
• Mattflaschen-WMF assigned this task to EBernhardson.Jan 12 2015, 7:23 PM
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.
gerritbot added a comment.Jan 13 2015, 3:34 PM

Change 180217 merged by jenkins-bot:
Use unitless line-height for consistent inheritance

https://gerrit.wikimedia.org/r/180217

matthiasmullie mentioned this in rEFLWcec52a85e8a1: Use unitless line-height for consistent inheritance.Jan 13 2015, 3:34 PM
matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Triage board.Jan 13 2015, 3:41 PM
DannyH moved this task from Product Review to Done (see also Status=Resolved) on the Collaboration-Team-Triage board.Jan 23 2015, 7:33 PM
Quiddity closed this task as Resolved.Jan 28 2015, 7:39 PM
Diffusion mentioned this in rMEXT3f0cbe45931f: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:22 AM
Diffusion mentioned this in rMEXT47fbcb5fbe93: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….
RandomDSdevel awarded a token.Mar 29 2015, 10:27 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL