Page MenuHomePhabricator

Monobook: Topic titlebar needs better line spacing when the title is longer than one line
Closed, ResolvedPublic

Description

See attachment.

In Monobook, topic titles that run longer than one line look terrible. We need to add better line spacing for the title.


Trello card: SBKOELrs

Event Timeline

Spage raised the priority of this task from to Medium.Dec 3 2014, 12:22 PM

Change 177165 had a related patch set uploaded (by EBernhardson):
Fix bad spacing in topic title on monobook

https://gerrit.wikimedia.org/r/177165

Patch-For-Review

Change 177165 merged by jenkins-bot:
Fix bad spacing in topic title on monobook

https://gerrit.wikimedia.org/r/177165

This isn't working, on ee-flow or mediawiki. Is it up anywhere?

eeflow_four_score.jpg (730×1 px, 380 KB)

Change 180217 had a related patch set uploaded (by EBernhardson):
Use unitless line-height for consistent inheritance

https://gerrit.wikimedia.org/r/180217

Patch-For-Review

We fixed it in a few places, but it still triggers under one condition that you seem to have hit :) One-line patch above should finish fixing it.

Change 180217 merged by jenkins-bot:
Use unitless line-height for consistent inheritance

https://gerrit.wikimedia.org/r/180217