Maniphest T76620

Still issues with pinch zoom on images
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Dec 3 2014, 5:30 PM

Tags

Referenced Files

None

Subscribers

Tokens

"Haypence" token, awarded by RandomDSdevel.

Description

When I view images on Wikipedia Mobile, I cannot properly zoom in to them by pinching. The images do zoom, but the zooming action isn't centered where I've tried to zoom. Instead, the action takes place at the top left of the image, importantly without the ability to swipe around to see the rest of the image. This means that I'm only able to view the image in its entirety unzoomed, which is smaller than I would like on a tiny phone screen.

Details

	Subject	Repo	Branch	Lines +/-
	Fix pinch zoom on images	mediawiki/extensions/MobileFrontend	master	+2 -14
	Fix image pinch zoom	mediawiki/extensions/MobileFrontend	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned In: rMEXT316b2bbcdf6b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rMEXTb51a3d541602: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend…
rEMFR561adaf71c5c: Fix pinch zoom on images
rEMFR4a7e59b76340: Fix image pinch zoom

Event Timeline

Jdlrobson created this task.Dec 3 2014, 5:30 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson changed Security from none to None.

Jdlrobson subscribed.

This bug is tracked here: https://trello.com/c/75WL5dbP/4-bug-t76620-still-issues-with-pinch-zoom-on-images

• KLans_WMF triaged this task as Medium priority.Dec 3 2014, 6:58 PM

Jdlrobson moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Dec 5 2014, 7:15 PM

Change 182295 had a related patch set uploaded (by Bmansurov):
Fix image pinch zoom

https://gerrit.wikimedia.org/r/182295

Patch-For-Review

• bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog board.Dec 30 2014, 10:13 PM

Change 182295 merged by jenkins-bot:
Fix image pinch zoom

https://gerrit.wikimedia.org/r/182295

• bmansurov mentioned this in rEMFR4a7e59b76340: Fix image pinch zoom.Dec 31 2014, 12:40 AM

Hmm. The patch doesn't seem to have really fixed the problem, although it also doesn't make things any worse (and simplifies the CSS).

Moving back to patch needed

Jdlrobson moved this task from Needs Prioritization to 2015-16 Q4 on the Web-Team-Backlog board.Dec 31 2014, 7:21 PM

Change 183904 had a related patch set uploaded (by Bmansurov):
Fix pinch zoom on images

https://gerrit.wikimedia.org/r/183904

Patch-For-Review

• bmansurov claimed this task.Jan 9 2015, 8:38 PM

• bmansurov moved this task from 2015-16 Q4 to Needs Prioritization on the Web-Team-Backlog board.

Change 183904 merged by jenkins-bot:
Fix pinch zoom on images

https://gerrit.wikimedia.org/r/183904

• bmansurov mentioned this in rEMFR561adaf71c5c: Fix pinch zoom on images.Jan 9 2015, 9:03 PM

Jdlrobson closed this task as Resolved.Jan 9 2015, 10:48 PM

Diffusion mentioned this in rMEXTb51a3d541602: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Mar 11 2015, 6:23 AM

Diffusion mentioned this in rMEXT316b2bbcdf6b: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….

RandomDSdevel awarded a token.Mar 29 2015, 10:47 PM

• Phabricator_maintenance moved this task from Needs Prioritization to 2014-15 Q3 on the Web-Team-Backlog board.Mar 7 2018, 4:28 AM