Rename a lot of getters for consistency
Closed, ResolvedPublic

Description

There are a very large number of changes, so older changes are hidden. Show Older Changes
Prtksxna updated the task description. (Show Details)Dec 14 2017, 8:08 AM

Change 398004 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] GroupElement: Rename getItem(s)FromData to findItem(s)FromData

https://gerrit.wikimedia.org/r/398004

Change 398209 merged by jenkins-bot:
[oojs/ui@master] Use findItem(s)FromData instead of getItem(s)FromData

https://gerrit.wikimedia.org/r/398209

Change 400466 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/Flow@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400466

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:07 AM

Change 400467 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CentralNotice@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400467

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:14 AM

Change 400468 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/TemplateData@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400468

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:17 AM

Change 400469 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400469

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:24 AM

Change 400470 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[VisualEditor/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400470

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:28 AM
Prtksxna updated the task description. (Show Details)Jan 3 2018, 5:56 AM
Prtksxna updated the task description. (Show Details)Jan 3 2018, 6:24 AM

Change 398005 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] SelectWidget: Rename getSelectedItem to findSelectedItem

https://gerrit.wikimedia.org/r/398005

Change 398006 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] MultiSelectWidget: Rename getters

https://gerrit.wikimedia.org/r/398006

Change 400470 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400470

Change 400466 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400466

Change 400468 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400468

Change 400469 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400469

Change 398217 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use findItem(s)FromData instead getItem(s)FromData

https://gerrit.wikimedia.org/r/398217

Change 398223 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Use findItem(s)FromData instead getItem(s)FromData

https://gerrit.wikimedia.org/r/398223

Change 398221 merged by jenkins-bot:
[mediawiki/core@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/398221

Change 398224 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use findItem(s)FromData instead getItem(s)FromData

https://gerrit.wikimedia.org/r/398224

Volker_E updated the task description. (Show Details)Jan 11 2018, 1:38 AM

Change 404513 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5428e9b3)

https://gerrit.wikimedia.org/r/404513

Change 404513 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5428e9b3)

https://gerrit.wikimedia.org/r/404513

Jdforrester-WMF updated the task description. (Show Details)

Change 400467 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400467

Volker_E updated the task description. (Show Details)Jan 29 2018, 9:53 PM

Change 414935 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CentralNotice@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414935

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:30 AM

Change 414936 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CollaborationKit@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414936

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:36 AM

Change 414937 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/ContentTranslation@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414937

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:40 AM

Change 414942 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/UploadWizard@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414942

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:49 AM

Change 414943 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/MultimediaViewer@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414943

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:58 AM

Change 414944 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414944

Prtksxna updated the task description. (Show Details)Feb 27 2018, 6:06 AM

Change 414943 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414943

Change 414942 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414942

Change 414937 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414937

Change 414936 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414936

Change 414944 merged by jenkins-bot:
[mediawiki/core@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414944

Change 414935 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414935

Prtksxna updated the task description. (Show Details)Feb 28 2018, 5:04 AM
Prtksxna updated the task description. (Show Details)Feb 28 2018, 5:07 AM

Change 415224 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415224

Change 415225 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/UploadWizard@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415225

Prtksxna updated the task description. (Show Details)Feb 28 2018, 5:59 AM

Change 415226 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/UploadWizard@master] Use findSelectedItemsData instead of getSelectedItemsData

https://gerrit.wikimedia.org/r/415226

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:02 AM

Change 415227 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] [BREAKING CHANGE] GroupElement: Remove getItem(s)FromData

https://gerrit.wikimedia.org/r/415227

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:18 AM

Change 415229 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] [BREAKING CHANGE] SelectWidget: Remove getSelectedItem

https://gerrit.wikimedia.org/r/415229

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:22 AM

Change 415231 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] [BREAKING CHANGE] MultiSelectWidget: Remove getSelectedItems and getSelectedItemsData

https://gerrit.wikimedia.org/r/415231

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:25 AM

Change 415225 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415225

Change 415224 merged by jenkins-bot:
[mediawiki/core@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415224

Change 415226 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use findSelectedItemsData instead of getSelectedItemsData

https://gerrit.wikimedia.org/r/415226

Volker_E updated the task description. (Show Details)Mar 1 2018, 6:28 PM
Volker_E updated the task description. (Show Details)
Jdforrester-WMF closed this task as Resolved.May 7 2018, 8:47 PM
Jdforrester-WMF assigned this task to Prtksxna.
Jdforrester-WMF edited projects, added OOUI (OOUI-0.27.0); removed Patch-For-Review, OOUI.
Jdforrester-WMF updated the task description. (Show Details)

Change 415229 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] SelectWidget: Remove getSelectedItem

https://gerrit.wikimedia.org/r/415229

Change 415231 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] MultiSelectWidget: Remove getSelectedItems and getSelectedItemsData

https://gerrit.wikimedia.org/r/415231

Change 415227 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] GroupElement: Remove getItem(s)FromData

https://gerrit.wikimedia.org/r/415227

Excellent work!