Page MenuHomePhabricator
Create Task
Maniphest T76630

Rename a lot of getters for consistency
Closed, ResolvedPublic
Actions

Description

Details

ProjectBranchLines +/-Subject
oojs/uimaster+0 -24[BREAKING CHANGE] GroupElement: Remove getItem(s)FromData
oojs/uimaster+0 -22[BREAKING CHANGE] MultiSelectWidget: Remove getSelectedItems and getSelectedItemsData
oojs/uimaster+0 -11[BREAKING CHANGE] SelectWidget: Remove getSelectedItem
mediawiki/extensions/UploadWizardmaster+3 -3Use findSelectedItemsData instead of getSelectedItemsData
mediawiki/coremaster+20 -20Use findSelectedItems instead of getSelectedItems
mediawiki/extensions/UploadWizardmaster+4 -4Use findSelectedItems instead of getSelectedItems
mediawiki/coremaster+3 -3Use findSelectedItem instead of getSelectedItem
mediawiki/extensions/CentralNoticemaster+1 -1Use findSelectedItem instead of getSelectedItem
mediawiki/extensions/CollaborationKitmaster+3 -3Use findSelectedItem instead of getSelectedItem
mediawiki/extensions/ContentTranslationmaster+5 -5Use findSelectedItem instead of getSelectedItem
mediawiki/extensions/UploadWizardmaster+1 -1Use findSelectedItem instead of getSelectedItem
mediawiki/extensions/MultimediaViewermaster+18 -18Use findSelectedItem instead of getSelectedItem
mediawiki/extensions/CentralNoticemaster+8 -8Use findItemFromData instead getItemFromData
mediawiki/extensions/VisualEditormaster+1 -1Update VE core submodule to master (d5428e9b3)
oojs/uimaster+13 -2[DEPRECATING CHANGE] SelectWidget: Rename getSelectedItem to findSelectedItem
mediawiki/extensions/Echomaster+6 -6Use findItem(s)FromData instead getItem(s)FromData
mediawiki/coremaster+8 -8Use findItemFromData instead getItemFromData
mediawiki/extensions/AdvancedSearchmaster+7 -7Use findItem(s)FromData instead getItem(s)FromData
mediawiki/extensions/ContentTranslationmaster+4 -4Use findItem(s)FromData instead getItem(s)FromData
mediawiki/extensions/VisualEditormaster+1 -1Use findItemFromData instead getItemFromData
mediawiki/extensions/TemplateDatamaster+2 -2Use findItemFromData instead getItemFromData
mediawiki/extensions/Flowmaster+2 -2Use findItemFromData instead getItemFromData
VisualEditor/VisualEditormaster+7 -7Use findItemFromData instead getItemFromData
oojs/uimaster+27 -5[DEPRECATING CHANGE] MultiSelectWidget: Rename getters
oojs/uimaster+25 -25Use findItem(s)FromData instead of getItem(s)FromData
oojs/uimaster+30 -6[DEPRECATING CHANGE] GroupElement: Rename getItem(s)FromData to findItem(s)FromData
oojs/uimaster+0 -12[BREAKING CHANGE] SelectWidget: Remove getFirstSelectableItem
oojs/uimaster+0 -18[BREAKING CHANGE] SelectWidget: Remove getRelativeSelectableItem
oojs/uimaster+0 -12[BREAKING CHANGE] Remove BookletLayout#getClosestPage
oojs/uimaster+0 -11[BREAKING CHANGE] SelectWidget: Remove getHighlightedItem
mediawiki/coremaster+2 -2RCFilters: Use findRelativeSelectableItem instead of getRelativeSelectableitem
mediawiki/coremaster+1 -1apisandbox.js: Use findFirstSelectableitem instead of getFirstSelectableItem
mediawiki/extensions/VisualEditormaster+1 -1Use findFirstSelectableitem instead of getFirstSelectableItem
VisualEditor/VisualEditormaster+2 -2Use findFirstSelectableitem instead of getFirstSelectableItem
mediawiki/extensions/TemplateDatamaster+1 -1Use findFirstSelectableitem instead of getFirstSelectableItem
oojs/uimaster+6 -6Use findRelativeSelectableItem instead of getRelativeSelectableItem
oojs/uimaster+20 -2[DEPRECATING CHANGE] SelectWidget: Rename getRelativeSelectableItem to findRelativeSelectableItem
oojs/uimaster+5 -5Use findFirstSelectableItem instead of getFirstSelectableItem
oojs/uimaster+8 -8Use findHighlightedItem instead of getHighlightedItem
oojs/uimaster+13 -2[DEPRECATING CHANGE] SelectWidget: Rename getHighlightedItem to findHighlightedItem
oojs/uimaster+14 -2[DEPRECATING CHANGE] SelectWidget: Rename getFirstSelectableItem to findFirstSelectableItem
oojs/uimaster+10 -10[BREAKING CHANGE] SelectWidget: Rename getHighlightedItem to findHighlightedItem
mediawiki/extensions/VisualEditormaster+2 -2MWTemplateDialog: BookletLayout: Use findClosestPage instead of getClosestPage
oojs/uimaster+14 -2[DEPRECATING CHANGE] BookletLayout: Rename getClosestPage to findClosestPage
oojs/uimaster+6 -6Toolgroup: Rename getTargetTool to findTargetTool
oojs/uimaster+6 -6SelectFileWidget: Rename getTargetItem to findTargetItem
oojs/uimaster+1 -1[BREAKING CHANGE] Rename BookletLayout#getPageName → #getCurrentPageName
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Dec 15 2017, 6:08 PM

Change 398004 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] GroupElement: Rename getItem(s)FromData to findItem(s)FromData

https://gerrit.wikimedia.org/r/398004

Jdforrester-WMF updated the task description. (Show Details)Dec 15 2017, 6:18 PM
gerritbot added a comment.Dec 15 2017, 6:25 PM

Change 398209 merged by jenkins-bot:
[oojs/ui@master] Use findItem(s)FromData instead of getItem(s)FromData

https://gerrit.wikimedia.org/r/398209

gerritbot added a comment.Dec 28 2017, 6:06 AM

Change 400466 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/Flow@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400466

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:07 AM
gerritbot added a comment.Dec 28 2017, 6:13 AM

Change 400467 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CentralNotice@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400467

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:14 AM
gerritbot added a comment.Dec 28 2017, 6:16 AM

Change 400468 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/TemplateData@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400468

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:17 AM
gerritbot added a comment.Dec 28 2017, 6:23 AM

Change 400469 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400469

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:24 AM
gerritbot added a comment.Dec 28 2017, 6:28 AM

Change 400470 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[VisualEditor/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400470

Prtksxna updated the task description. (Show Details)Dec 28 2017, 6:28 AM
Prtksxna updated the task description. (Show Details)Jan 3 2018, 5:56 AM
Prtksxna updated the task description. (Show Details)Jan 3 2018, 6:24 AM
Jdforrester-WMF updated the task description. (Show Details)Jan 3 2018, 9:05 PM
gerritbot added a comment.Jan 3 2018, 9:19 PM

Change 398005 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] SelectWidget: Rename getSelectedItem to findSelectedItem

https://gerrit.wikimedia.org/r/398005

gerritbot added a comment.Jan 3 2018, 9:19 PM

Change 398006 merged by jenkins-bot:
[oojs/ui@master] [DEPRECATING CHANGE] MultiSelectWidget: Rename getters

https://gerrit.wikimedia.org/r/398006

Jdforrester-WMF moved this task from Reviewing to Waiting for breaking release on the OOUI board.Jan 8 2018, 7:42 PM
Jdforrester-WMF mentioned this in rEASRf829b89e7be1: Use findItem(s)FromData instead getItem(s)FromData.Jan 10 2018, 7:43 PM
gerritbot added a comment.Jan 10 2018, 7:46 PM

Change 400470 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400470

Jdforrester-WMF updated the task description. (Show Details)Jan 10 2018, 7:48 PM
gerritbot added a comment.Jan 10 2018, 7:51 PM

Change 400466 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400466

gerritbot added a comment.Jan 10 2018, 7:51 PM

Change 400468 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400468

gerritbot added a comment.Jan 10 2018, 7:54 PM

Change 400469 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400469

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)); removed MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)).Jan 10 2018, 8:00 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 10 2018, 8:08 PM
Jdforrester-WMF closed subtask T184040: TemplateData: Replace "getSelectedItem" with "findSelectedItem" as Resolved.Jan 10 2018, 8:11 PM
Jdforrester-WMF closed subtask T184039: Flow: Replace "getSelectedItem" with "findSelectedItem" as Resolved.Jan 10 2018, 8:13 PM
Jdforrester-WMF closed subtask T184041: Score: Replace "getSelectedItem" with "findSelectedItem" as Resolved.
Jdforrester-WMF closed subtask T184037: Cite: Replace "getSelectedItem" with "findSelectedItem" as Resolved.
Jdforrester-WMF updated the task description. (Show Details)Jan 10 2018, 8:16 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 10 2018, 8:18 PM
gerritbot added a comment.Jan 10 2018, 8:37 PM

Change 398217 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use findItem(s)FromData instead getItem(s)FromData

https://gerrit.wikimedia.org/r/398217

gerritbot added a comment.Jan 10 2018, 8:37 PM

Change 398223 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Use findItem(s)FromData instead getItem(s)FromData

https://gerrit.wikimedia.org/r/398223

gerritbot added a comment.Jan 10 2018, 8:39 PM

Change 398221 merged by jenkins-bot:
[mediawiki/core@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/398221

gerritbot added a comment.Jan 11 2018, 1:37 AM

Change 398224 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use findItem(s)FromData instead getItem(s)FromData

https://gerrit.wikimedia.org/r/398224

Volker_E updated the task description. (Show Details)Jan 11 2018, 1:38 AM
Jdforrester-WMF updated the task description. (Show Details)Jan 12 2018, 6:06 PM
gerritbot added a comment.Jan 16 2018, 6:24 PM

Change 404513 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5428e9b3)

https://gerrit.wikimedia.org/r/404513

gerritbot added a comment.Jan 17 2018, 5:29 PM

Change 404513 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (d5428e9b3)

https://gerrit.wikimedia.org/r/404513

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)); removed MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)).Jan 17 2018, 6:00 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 17 2018, 7:31 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)Jan 17 2018, 7:33 PM
gerritbot added a comment.Jan 29 2018, 9:49 PM

Change 400467 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Use findItemFromData instead getItemFromData

https://gerrit.wikimedia.org/r/400467

Volker_E updated the task description. (Show Details)Jan 29 2018, 9:53 PM
gerritbot added a comment.Feb 27 2018, 5:29 AM

Change 414935 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CentralNotice@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414935

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:30 AM
gerritbot added a comment.Feb 27 2018, 5:34 AM

Change 414936 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/CollaborationKit@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414936

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:36 AM
Prtksxna mentioned this in rECKT5f70417f461f: Use findSelectedItem instead of getSelectedItem.Feb 27 2018, 5:38 AM
gerritbot added a comment.Feb 27 2018, 5:39 AM

Change 414937 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/ContentTranslation@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414937

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:40 AM
gerritbot added a comment.Feb 27 2018, 5:49 AM

Change 414942 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/UploadWizard@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414942

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:49 AM
gerritbot added a comment.Feb 27 2018, 5:58 AM

Change 414943 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/MultimediaViewer@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414943

Prtksxna updated the task description. (Show Details)Feb 27 2018, 5:58 AM
gerritbot added a comment.Feb 27 2018, 6:06 AM

Change 414944 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414944

Prtksxna updated the task description. (Show Details)Feb 27 2018, 6:06 AM
gerritbot added a comment.Feb 27 2018, 4:23 PM

Change 414943 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414943

gerritbot added a comment.Feb 27 2018, 5:21 PM

Change 414942 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414942

gerritbot added a comment.Feb 27 2018, 6:44 PM

Change 414937 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414937

Prtksxna mentioned this in rECKT0345b406e405: Use findSelectedItem instead of getSelectedItem.Feb 27 2018, 6:47 PM
gerritbot added a comment.Feb 27 2018, 6:51 PM

Change 414936 merged by jenkins-bot:
[mediawiki/extensions/CollaborationKit@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414936

gerritbot added a comment.Feb 27 2018, 7:04 PM

Change 414944 merged by jenkins-bot:
[mediawiki/core@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414944

gerritbot added a comment.Feb 27 2018, 7:15 PM

Change 414935 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Use findSelectedItem instead of getSelectedItem

https://gerrit.wikimedia.org/r/414935

Jdforrester-WMF updated the task description. (Show Details)Feb 27 2018, 8:16 PM
Prtksxna updated the task description. (Show Details)Feb 28 2018, 5:04 AM
Prtksxna updated the task description. (Show Details)Feb 28 2018, 5:07 AM
gerritbot added a comment.Feb 28 2018, 5:53 AM

Change 415224 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/core@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415224

gerritbot added a comment.Feb 28 2018, 5:58 AM

Change 415225 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/UploadWizard@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415225

Prtksxna updated the task description. (Show Details)Feb 28 2018, 5:59 AM
gerritbot added a comment.Feb 28 2018, 6:02 AM

Change 415226 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[mediawiki/extensions/UploadWizard@master] Use findSelectedItemsData instead of getSelectedItemsData

https://gerrit.wikimedia.org/r/415226

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:02 AM
gerritbot added a comment.Feb 28 2018, 6:13 AM

Change 415227 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] [BREAKING CHANGE] GroupElement: Remove getItem(s)FromData

https://gerrit.wikimedia.org/r/415227

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:18 AM
gerritbot added a comment.Feb 28 2018, 6:22 AM

Change 415229 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] [BREAKING CHANGE] SelectWidget: Remove getSelectedItem

https://gerrit.wikimedia.org/r/415229

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:22 AM
gerritbot added a comment.Feb 28 2018, 6:25 AM

Change 415231 had a related patch set uploaded (by Prtksxna; owner: Prtksxna):
[oojs/ui@master] [BREAKING CHANGE] MultiSelectWidget: Remove getSelectedItems and getSelectedItemsData

https://gerrit.wikimedia.org/r/415231

Prtksxna updated the task description. (Show Details)Feb 28 2018, 6:25 AM
gerritbot added a comment.Feb 28 2018, 11:51 PM

Change 415225 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415225

gerritbot added a comment.Mar 1 2018, 12:02 AM

Change 415224 merged by jenkins-bot:
[mediawiki/core@master] Use findSelectedItems instead of getSelectedItems

https://gerrit.wikimedia.org/r/415224

gerritbot added a comment.Mar 1 2018, 6:25 PM

Change 415226 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Use findSelectedItemsData instead of getSelectedItemsData

https://gerrit.wikimedia.org/r/415226

Volker_E updated the task description. (Show Details)Mar 1 2018, 6:28 PM
Volker_E updated the task description. (Show Details)
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)); removed MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Mar 6 2018, 10:01 AM
Jdforrester-WMF closed this task as Resolved.May 7 2018, 8:47 PM
Jdforrester-WMF assigned this task to Prtksxna.
Jdforrester-WMF edited projects, added OOUI (OOUI-0.27.0); removed Patch-For-Review, OOUI.
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.May 7 2018, 8:50 PM

Change 415229 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] SelectWidget: Remove getSelectedItem

https://gerrit.wikimedia.org/r/415229

gerritbot added a comment.May 7 2018, 8:50 PM

Change 415231 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] MultiSelectWidget: Remove getSelectedItems and getSelectedItemsData

https://gerrit.wikimedia.org/r/415231

gerritbot added a comment.May 7 2018, 8:51 PM

Change 415227 merged by jenkins-bot:
[oojs/ui@master] [BREAKING CHANGE] GroupElement: Remove getItem(s)FromData

https://gerrit.wikimedia.org/r/415227

Volker_E added a comment.May 7 2018, 8:57 PM

Excellent work!

Volker_E awarded a token.May 7 2018, 8:57 PM
WhitePhosphorus mentioned this in T309578: Replace "getSelectedItem" with "findSelectedItem" in core documentation.May 31 2022, 5:50 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL