Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open.
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	Swainr
	Dec 4 2014, 2:33 PM

Description

Environment- beta, test2

1>Open the language inspector on an empty page.
2>While the inspector is open, select any heading format.
JS error Uncaught Error: “Offset could not be translated to a DOM element and offset: 2”.Screenshot attached.

Details

	Subject	Repo	Branch	Lines +/-
	Close inspectors before executing a ve.ui.Tool command	VisualEditor/VisualEditor	master	+12 -2

Customize query in gerrit

Related Objects

Mentioned In: T74950: VisualEditor: [Regression wmf6]“Uncaught Error: Inserted data is trying to close the root node (at index 0)” when applying heading formats with language inspector open.
Mentioned Here: T117620: Write a scheduler singleton to execute code after some other code
T98820: Clicking on References list from the toolbar menu while keeping the Cite dialog open throws error " Offset could not be translated to a DOM element "
T74950: VisualEditor: [Regression wmf6]“Uncaught Error: Inserted data is trying to close the root node (at index 0)” when applying heading formats with language inspector open.

Event Timeline

Browsers-Chrome 39,FF 33.1.1

Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Dec 5 2014, 6:33 PM

I can't reproduce this. Seems similar to T74950 though

Actually I got this, but I had to start with a blank document. Will change the task description.

Krenair updated the task description. (Show Details)Jan 10 2015, 1:19 AM

Jdforrester-WMF renamed this task from [Regression pre-wmf12]- Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. to [Regression wmf12] Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open..Jan 10 2015, 1:19 AM

Jdforrester-WMF edited projects, added VisualEditor-EditingTools; removed VisualEditor-MediaWiki.

Krenair mentioned this in T74950: VisualEditor: [Regression wmf6]“Uncaught Error: Inserted data is trying to close the root node (at index 0)” when applying heading formats with language inspector open..Jan 10 2015, 2:00 PM

Jdforrester-WMF moved this task from External and Administrivia to Freezer on the VisualEditor board.Jan 15 2015, 12:51 AM

T98820 is probably a duplicate too

Comes down to the inspector closing, and trying to restore the selection by doing context.getSurface().getView().focus(); ...and discovering that it has a bad idea what the selection should be. (Specifically, it thinks the selection is at index 2, when the max allowable would be 1.)

Change 250646 had a related patch set uploaded (by DLynch):
Forcibly trigger a selection when using a Tool, to close inspectors

https://gerrit.wikimedia.org/r/250646

gerritbot added a project: Patch-For-Review.Nov 3 2015, 7:53 AM

dchan added a subtask: T117620: Write a scheduler singleton to execute code after some other code.Nov 3 2015, 11:23 PM

@DLynch and I decided this should wait for the basic scheduler singleton (T117620 ), which should be implementable fairly quickly, rather than further increasing the setTimeout complexity of the codebase.

Change 250904 had a related patch set uploaded (by DLynch):
Add ve.Scheduler, use it to avoid conflict in ve.ui.Tool

https://gerrit.wikimedia.org/r/250904

Change 250646 merged by jenkins-bot:
Close inspectors before executing a ve.ui.Tool command

https://gerrit.wikimedia.org/r/250646

Jdforrester-WMF removed a subtask: T117620: Write a scheduler singleton to execute code after some other code.Nov 9 2015, 11:29 PM

Jdforrester-WMF renamed this task from [Regression wmf12] Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open. to Uncaught Error: “Offset could not be translated to a DOM element and offset: 2” when selecting a heading format with language inspector open..Nov 10 2015, 12:46 AM

Jdforrester-WMF closed this task as Resolved.

Jdforrester-WMF assigned this task to DLynch.

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)).

Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Nov 16 2015, 6:51 PM