Page MenuHomePhabricator

HHVM's xhprof_frame_begin() calls from XhprofFrame constructor closed too soon
Closed, DeclinedPublic

Description

Filed upstream as https://github.com/facebook/hhvm/issues/4354:

The current implementation closes the artificial frame when XhprofFrame::__construct returns and instead leaves the XhprofFrame::__construct frame on the call trace stack. The artificial frame should either be inserted in the call trace stack below the XhprofFrame::__construct frame or the XhprofFrame::__construct should not create and destroy a frame on the stack at all.

Event Timeline

bd808 raised the priority of this task from to Needs Triage.
bd808 updated the task description. (Show Details)
bd808 added projects: Librarization, Upstream, HHVM.
bd808 changed Security from none to None.
bd808 added subscribers: bd808, aaron.

We aren't currently planning on using XhprofFrame, but the same bug effect xhprof_frame_begin() calls made from ProfilerXhprof::scopedProfileIn(). A workaround for this would be to exclude ProfilerXhprof::scopedProfileIn() from profiling, but unfortunately that functionality is also missing from HHVM's XHProf implementation (T76830: HHVM's xhprof does not honor 'ignored_functions' option).

bd808 changed the task status from Open to Stalled.Dec 11 2014, 1:21 AM
bd808 triaged this task as Medium priority.
bd808 lowered the priority of this task from Medium to Lowest.Dec 22 2014, 11:11 PM
Krinkle added a subscriber: Krinkle.

Closing per T192166.