Page MenuHomePhabricator
Create Task
Maniphest T76831

HHVM's xhprof_frame_begin() calls from XhprofFrame constructor closed too soon
Closed, DeclinedPublic
Actions

Description

Filed upstream as https://github.com/facebook/hhvm/issues/4354:

The current implementation closes the artificial frame when XhprofFrame::__construct returns and instead leaves the XhprofFrame::__construct frame on the call trace stack. The artificial frame should either be inserted in the call trace stack below the XhprofFrame::__construct frame or the XhprofFrame::__construct should not create and destroy a frame on the stack at all.

Related Objects

Event Timeline

• bd808 created this task.Dec 5 2014, 4:25 AM
• bd808 raised the priority of this task from to Needs Triage.
• bd808 updated the task description. (Show Details)
• bd808 added projects: Librarization, Upstream, HHVM.
• bd808 changed Security from none to None.
• bd808 added subscribers: • bd808, aaron.
• bd808 added a comment.Dec 5 2014, 4:29 AM

We aren't currently planning on using XhprofFrame, but the same bug effect xhprof_frame_begin() calls made from ProfilerXhprof::scopedProfileIn(). A workaround for this would be to exclude ProfilerXhprof::scopedProfileIn() from profiling, but unfortunately that functionality is also missing from HHVM's XHProf implementation (T76830: HHVM's xhprof does not honor 'ignored_functions' option).

• bd808 changed the task status from Open to Stalled.Dec 11 2014, 1:21 AM
• bd808 triaged this task as Medium priority.
• bd808 mentioned this in T1251: RfC: Better PHP profiling.Dec 11 2014, 1:30 AM
• bd808 lowered the priority of this task from Medium to Lowest.Dec 22 2014, 11:11 PM
Krenair moved this task from Backlog to Reported Upstream on the Upstream board.Mar 29 2015, 8:35 PM
Krinkle updated the task description. (Show Details)Dec 18 2017, 3:24 PM
Krinkle moved this task from Backlog to Defect on the HHVM board.Dec 18 2017, 4:53 PM
Krinkle closed this task as Declined.Oct 3 2019, 3:23 AM
Krinkle subscribed.

Closing per T192166.

Krinkle added a project: Performance-Team.Oct 3 2019, 3:23 AM
Krinkle edited projects, added: MediaWiki-Debug-Logger; removed: Librarization.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits