Page MenuHomePhabricator
Create Task
Maniphest T77124

Refactor the transport system
Closed, ResolvedPublic
Actions

Description

Things I want to do so far:

  1. Remove callbacks from the objects, use event emitters instead.
  2. Remove the upload object from the constructor, and deal with the fallout from that.
  3. Maybe have a superclass for the transports that will make this a bit easier...not sure how yet.

Details

SubjectRepoBranchLines +/-
Remove references to upload in FirefoggTransportmediawiki/extensions/UploadWizardmaster+42 -33
Remove upload object from FDTmediawiki/extensions/UploadWizardmaster+47 -38
Replace Firefogg callbacks with OOJS eventsmediawiki/extensions/UploadWizardmaster+189 -184
Replace FDT callbacks with OOJS eventsmediawiki/extensions/UploadWizardmaster+329 -309
Replace IframeTransport callbacks with OOJS eventsmediawiki/extensions/UploadWizardmaster+97 -95
Customize query in gerrit

Related Objects

Event Timeline

MarkTraceur created this task.Dec 8 2014, 4:18 PM
MarkTraceur claimed this task.
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added projects: UploadWizard, UploadWizard-Refactoring, Multimedia.
MarkTraceur changed Security from none to None.
MarkTraceur moved this task from Untriaged to Next up on the Multimedia board.
MarkTraceur subscribed.
gerritbot added a project: Patch-For-Review.Dec 8 2014, 4:29 PM

Change 178207 had a related patch set uploaded (by MarkTraceur):
Replace FDT callbacks with OOJS events

https://gerrit.wikimedia.org/r/178207

Patch-For-Review

gerritbot added a comment.Dec 8 2014, 4:56 PM

Change 178210 had a related patch set uploaded (by MarkTraceur):
Replace Firefogg callbacks with OOJS events

https://gerrit.wikimedia.org/r/178210

Patch-For-Review

gerritbot added a comment.Dec 8 2014, 5:55 PM

Change 178223 had a related patch set uploaded (by MarkTraceur):
Replace IframeTransport callbacks with OOJS events

https://gerrit.wikimedia.org/r/178223

Patch-For-Review

gerritbot added a comment.Dec 8 2014, 6:29 PM

Change 178230 had a related patch set uploaded (by MarkTraceur):
Remove references to upload in FirefoggTransport

https://gerrit.wikimedia.org/r/178230

Patch-For-Review

gerritbot added a comment.Dec 8 2014, 6:55 PM

Change 178241 had a related patch set uploaded (by MarkTraceur):
Remove upload object from FDT

https://gerrit.wikimedia.org/r/178241

Patch-For-Review

MarkTraceur moved this task from Next up to Needs code review on the Multimedia board.Dec 8 2014, 6:58 PM
• Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 9 2014, 4:31 PM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 9 2014, 6:30 PM
• Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 11 2014, 8:53 AM
gerritbot added a comment.Dec 15 2014, 9:53 AM

Change 178223 merged by jenkins-bot:
Replace IframeTransport callbacks with OOJS events

https://gerrit.wikimedia.org/r/178223

• Gilles mentioned this in rEUWI1b966c825838: Replace IframeTransport callbacks with OOJS events.Dec 15 2014, 9:53 AM
gerritbot added a comment.Dec 15 2014, 3:16 PM

Change 178207 merged by jenkins-bot:
Replace FDT callbacks with OOJS events

https://gerrit.wikimedia.org/r/178207

MarkTraceur mentioned this in rEUWI11425ed2cb95: Replace FDT callbacks with OOJS events.Dec 15 2014, 3:16 PM
gerritbot added a comment.Dec 15 2014, 3:24 PM

Change 178210 merged by jenkins-bot:
Replace Firefogg callbacks with OOJS events

https://gerrit.wikimedia.org/r/178210

MarkTraceur mentioned this in rEUWI77385ba21468: Replace Firefogg callbacks with OOJS events.Dec 15 2014, 3:24 PM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 15 2014, 3:32 PM
gerritbot added a comment.Dec 15 2014, 4:20 PM

Change 178241 merged by jenkins-bot:
Remove upload object from FDT

https://gerrit.wikimedia.org/r/178241

MarkTraceur mentioned this in rEUWI5c293bf0c789: Remove upload object from FDT.Dec 15 2014, 4:20 PM
gerritbot added a comment.Dec 16 2014, 9:28 AM

Change 178230 merged by jenkins-bot:
Remove references to upload in FirefoggTransport

https://gerrit.wikimedia.org/r/178230

• Gilles moved this task from Needs code review to Ready for testing on the Multimedia board.Dec 16 2014, 9:28 AM
MarkTraceur mentioned this in rEUWI72abd539a39e: Remove references to upload in FirefoggTransport.Dec 16 2014, 9:29 AM
• Gilles moved this task from Ready for testing to Doing on the Multimedia board.Dec 17 2014, 3:32 PM
• Gilles closed this task as Resolved.Dec 18 2014, 8:49 AM
• Gilles moved this task from Doing to Done on the Multimedia board.
• Gilles subscribed.
MarkTraceur mentioned this in rMEXT6c8e2e1c539e: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:22 AM
MarkTraceur mentioned this in rMEXT8b526da8b8a1: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….
Diffusion mentioned this in rMEXTc702ddeae25a: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:22 AM
Diffusion mentioned this in rMEXT2c43c40b5789: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….
Diffusion mentioned this in rMEXT14470a35b474: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….
matmarex moved this task from Backlog to Finished on the UploadWizard-Refactoring board.Apr 24 2015, 6:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits