Centralize URL generation in a single component
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	MingleTerminator
	Dec 8 2014, 4:58 PM

Description

Migrated from: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/373

mmv.js, mmv.ui.reuse.share.js andmmv.ui.reuse.embed.js each need to generate MultimediaViewer-enabled URLs (probably the download tab will too). There should be a single small class focused on that task which can be shared by all components.

Related Objects

Mentioned Here: T77300: Use better encoding for MediaViewer URLs

Event Timeline

In mingle on 2014-03-19 at 19:29:57, @Tgr wrote:

See also #371 , #372 .

• Gilles added a project: MediaViewer.Dec 8 2014, 5:00 PM

Tgr added a project: Technical-Debt.Dec 11 2014, 3:55 AM

Tgr subscribed.

Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 5:55 PM

Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 5:55 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 3:51 PM

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:24 PM

MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 4 2016, 7:36 PM

Jdforrester-WMF unsubscribed.Jul 5 2016, 9:25 AM

MBinder_WMF added a project: Reading-Web-Tech-Debt.Oct 3 2016, 8:35 PM

MBinder_WMF edited projects, added Technical-Debt (RW-Tech-Debt); removed Technical-Debt.Oct 4 2016, 6:16 PM

MBinder_WMF removed a project: Reading-Web-Tech-Debt.Oct 4 2016, 7:54 PM

• bmansurov moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.Oct 7 2016, 5:31 PM

MBinder_WMF removed projects: Technical-Debt (RW-Tech-Debt), Web-Team-Backlog.Apr 13 2017, 6:39 PM

MBinder_WMF added a project: Multimedia.Aug 7 2017, 5:47 PM

simon04 added a project: Code-Health.Jun 10 2019, 7:13 AM

Aklapper removed a project: Code-Health.Jun 10 2019, 9:35 AM

Tgr unsubscribed.Jul 9 2019, 6:03 PM

Looks like this was resolved back in 2014, together with T77300, by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MultimediaViewer/+/125932. The code has changed since then, but it's still centralized, in 'mmv.head' #getMediaHash method: https://gerrit.wikimedia.org/g/mediawiki/extensions/MultimediaViewer/+/0683f3ecc8a502a0fb0759ac2fe3393126372f48/resources/mmv.head/base.js#46

Centralize URL generation in a single componentClosed, ResolvedPublicActions

Description

Related Objects

Event Timeline

Centralize URL generation in a single component
Closed, ResolvedPublic
Actions