Page MenuHomePhabricator
Create Task
Maniphest T77320

Get rid of EmbedFileInfo
Closed, ResolvedPublic
Actions

Description

Migrated from: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/395

In its latest version it is only used to wrap some other models; we could do without it.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Get Rid of EmbedFileInfomediawiki/extensions/MultimediaViewermaster+60 -114
Customize query in gerrit

Event Timeline

• MingleTerminator raised the priority of this task from to Medium.Dec 8 2014, 5:00 PM
• MingleTerminator added a project: Multimedia.
• Gilles added a project: MediaViewer.Dec 8 2014, 5:04 PM
• Tgr added a project: Technical-Debt.Dec 11 2014, 1:47 AM
• Tgr subscribed.
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:29 PM
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 6:29 PM
Jdforrester-WMF subscribed.Sep 21 2015, 3:41 PM

Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.

Jdforrester-WMF removed a project: Multimedia.Sep 21 2015, 3:51 PM
Danny_B moved this task from Unsorted to Needs removal on the Technical-Debt board.Jan 22 2016, 11:44 PM
Jdlrobson lowered the priority of this task from Medium to Low.Jan 28 2016, 10:33 PM
Jdlrobson subscribed.
MBinder_WMF added a project: Web-Team-Backlog-Archived.Apr 27 2016, 4:22 PM
MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.Jul 4 2016, 7:43 PM
Jdforrester-WMF unsubscribed.Jul 5 2016, 9:25 AM
MBinder_WMF added a project: Reading-Web-Tech-Debt.Oct 3 2016, 8:35 PM
MBinder_WMF edited projects, added Technical-Debt (RW-Tech-Debt); removed Technical-Debt.Oct 4 2016, 6:16 PM
MBinder_WMF removed a project: Reading-Web-Tech-Debt.Oct 4 2016, 7:54 PM
• bmansurov moved this task from Uncategorized to Clean-Up on the Technical-Debt (RW-Tech-Debt) board.Oct 7 2016, 5:31 PM
MBinder_WMF removed projects: Technical-Debt (RW-Tech-Debt), Web-Team-Backlog-Archived.Apr 13 2017, 6:39 PM
MarkTraceur moved this task from Backlog to Next on the MediaViewer board.Apr 27 2017, 3:52 PM
MarkTraceur added a project: good first task.
MarkTraceur subscribed.

This should be as simple as removing the class file and replacing wherever the constructor is called with a simple object with the correct properties.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 27 2017, 3:53 PM
MBinder_WMF added a project: Multimedia.Aug 7 2017, 5:39 PM
egardner claimed this task.Feb 5 2019, 6:51 PM
gerritbot subscribed.Feb 5 2019, 10:37 PM

Change 488196 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/MultimediaViewer@master] Get Rid of EmbedFileInfo (T77320)

https://gerrit.wikimedia.org/r/488196

gerritbot added a project: Patch-For-Review.Feb 5 2019, 10:37 PM
gerritbot added a comment.Feb 5 2019, 10:47 PM

Change 488196 had a related patch set uploaded (by Eric Gardner; owner: Eric Gardner):
[mediawiki/extensions/MultimediaViewer@master] Get Rid of EmbedFileInfo

https://gerrit.wikimedia.org/r/488196

gerritbot added a comment.Feb 6 2019, 12:17 AM

Change 488196 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Get Rid of EmbedFileInfo

https://gerrit.wikimedia.org/r/488196

Jdforrester-WMF closed this task as Resolved.Feb 6 2019, 12:20 AM
Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.17; 2019-02-12); removed Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits