Page MenuHomePhabricator

Generate a reference thumbnail for JPEGs
Closed, DuplicatePublic

Description

Migrated from: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/600

Narrative

As a developer, I can generate a reference thumbnail based on the original and generate arbitrary thumbnails based on that reference thumbnails, in order to save a CPU time on image scalers

Acceptance Criteria

  • Generate a reference thumbnail on demand
  • Generate arbitrary thumbnail sizes requested by users based on the that large thumbnail (if the requested size is smaller)
  • Support just JPEG to begin with

Related Bugs

https://bugzilla.wikimedia.org/show_bug.cgi?id=67525

https://bugzilla.wikimedia.org/show_bug.cgi?id=73352

Related Stories

#584

Related Changesets

Event Timeline

MingleTerminator raised the priority of this task from to High.
MingleTerminator added a project: Multimedia.
In mingle on 2014-05-28 at 09:25:42, @Gilles wrote:

https://gerrit.wikimedia.org/r/#/c/135008/

In mingle on 2014-07-19 at 01:48:46, @Tgr wrote:

See comments in https://bugzilla.wikimedia.org/show_bug.cgi?id=67525

This could easily be something beta-specific, though, or just me getting lost in the maze of misleadingly named machines and outdated documentation.

In mingle on 2014-07-25 at 20:08:52, @Tgr wrote:

Tested on beta and works as expected. I am moving it back to in development since I imagine we want to enable this in production, and that requires further work (at a minimum, writing the configuration patch, but possible more testing for PNGs, considering storage space and performance limitations etc.)

In mingle on 2014-07-28 at 15:48:42, @Gilles wrote:

Since Ops has given us the go on pregenerating thumbnails, I think we're ok on the storage front for this, considering that the intermediate steps are compressed. I'll try to get hold of bawolff to check that it wasn't just that he forgot to turn on the distance setting. And I'll do some PNG testing to check that there's no issue there.

In mingle on 2014-07-28 at 16:34:04, @Gilles wrote:

I've tested PNGs locally and I don't see any issue. I'll wait to see if Brian responds on bugzilla.

In mingle on 2014-07-29 at 12:05:05, @Gilles wrote:

Waiting for Brian's input to see if he has repro steps

In mingle on 2014-09-01 at 05:53:59, @Gilles wrote:

Brian provided repro steps. To be investigated.

In mingle on 2014-09-01 at 07:49:26, @Gilles wrote:

So far I can't repro

In mingle on 2014-09-23 at 14:57:38, @Gilles wrote:

I can finally repro

In mingle on 2014-09-24 at 14:04:44, @Gilles wrote:

Next step: deploy this to test wikis progressively.

In mingle on 2014-10-17 at 09:00:29, @Gilles wrote:

Let's wait to see how #301 pans out, deploying both at once would make things difficult to diagnose if something goes wrong.

In mingle on 2014-11-04 at 16:37:44, @Gilles wrote:

Deployed to beta. Next week: all wikis except commons.

In mingle on 2014-11-10 at 17:18:02, @Gilles wrote:

Deployed to all wikis except Commons. Doesn't work, gotta investigate why.

In mingle on 2014-11-12 at 11:20:33, @Tgr wrote:

Moving to awaiting other input - if I understand correctly, we are waiting for debug data.

In mingle on 2014-11-12 at 12:42:54, @Gilles wrote:

Well, it's a working investigation. I have to figure out what's not working. So, it's gong to keep moving between development and review as I figure things out.

In mingle on 2014-11-13 at 09:35:09, @Gilles wrote:

It's actually "working" in production, but there is a big problem with soft-rotated images. I'll check if the same issue happens locally and I'll un-deploy this on production wikis ASAP.

In mingle on 2014-11-20 at 00:41:47, @Tgr wrote:

All merged & SWATted. Still needs to be deployed to Commons.

In mingle on 2014-11-20 at 16:36:19, @Gilles wrote:

Tested on test.wikipedia.org, it works as expected. I'll do the Commons deploy next week, leaving some time for any bug reports we might receive from other wikis.

In mingle on 2014-11-26 at 16:26:24, @Gilles wrote:

Now tracked on phabricator