Page MenuHomePhabricator

Separate UploadWizard Flickr blacklist integration tests and Flickr API smoke tests
Open, LowPublic

Description

Migrated from: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/778

Currently the live Flickr API is tested as part of the standard test suite, which is suboptimal:

  • changes in the Flickr API will create test failures for unrelated changesets
  • if there are no new changes to the UploadWizard code, failures caused by a Flickr API change can go unnoticed
  • involving an external service makes the test suite slower, and causes it to fail if the test server is not set up for internet access.

The tests should mock out the Flickr API call; there should be a smoke test which uses the real Flickr API, but runs periodically and only with code from the master branch.