Page MenuHomePhabricator

Phabricator should use different email addresses to notify about actions of different contributors
Closed, DeclinedPublic

Description

When someone does an action (e.g. adds a comment), Phabricator sends an email with sender set to

[username] <no-reply@phabricator.wikimedia.org>

[username] changes but the rest doesn't; this confuses mail clients into thinking all mails are from the same person. This is how an opened Phabricator thread looks in Gmail:

phabricator_email_thread_in_gmail_detail_view.png (170×534 px, 21 KB)

This is how a thread looks in the thread list:

phabricator_email_thread_in_gmail_overview.png (25×1 px, 13 KB)

Note how all messages appear to come from the person who opened the bug. This makes it very hard to search or browse email notifications, especially when there are mass changes. (For example, a bot just created a hundred multimedia tickets; I would really like to see which ones have human activity, and Gmail is normally great at showing these things in the thread list view, by displaying the senders of all the unread messages in the thread:

gmail_overview_working.png (32×261 px, 5 KB)

but here that's broken by Phabricator's use of the same email address for all senders.

Ideally, email addresses in the From: field would look like

[username] <no-reply-[userid]@phabricator.wikimedia.org>

or something along those lines.

Event Timeline

Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added a project: Phabricator (Upstream).
Tgr changed Security from none to None.
Tgr subscribed.

For comparison, Bugzilla sent all bugmail from the same email address but did not add a sender name.
Personally I appreciate Phab's behavior because I have one item less (the actor) to filter on as it's already displayed in my mail client.

this confuses mail clients into thinking all mails are from the same person

Which mail clients except for the Gmail web interface are affected?
I rather consider the behavior that you describe a potential bug in Gmail, to be honest...

Ideally, email addresses in the From: field would look like

[username] <no-reply-[userid]@phabricator.wikimedia.org>

This would break filtering incoming mail by the criterion "sender address" and isn't desirable.
Using a plus sign as a sub-addressing tag might work in some MTAs and MUAs though (RFC 5233, no idea about Gmail).

Qgil triaged this task as Lowest priority.Dec 9 2014, 1:04 PM
Qgil moved this task from Backlog to Need Discussion on the Phabricator (Upstream) board.
Qgil subscribed.

For comparison, Bugzilla sent all bugmail from the same email address but did not add a sender name.
Personally I appreciate Phab's behavior because I have one item less (the actor) to filter on as it's already displayed in my mail client.

It's certainly an improvement to bugzilla, but in UX issues that's a fairly low bar :)

Which mail clients except for the Gmail web interface are affected?
I rather consider the behavior that you describe a potential bug in Gmail, to be honest...

IMO it's reasonable behavior in to conserve space in an extremely dense view, given that people who use different mail clients e.g. at home and at work often use different names for the same address. At any rate, given that Wikimedia uses Google Apps as an email provider, and Gmail is probably the most popular email client in general, it's reasonable to expect workarounds for bugs in Gmail. (If Phabricator did not work properly in IE 9 because of something that browser did not get right, would you say that should not be fixed because it's a bug in the browser and not in the web application? We are speaking about comparable market shares.)

Ideally, email addresses in the From: field would look like

[username] <no-reply-[userid]@phabricator.wikimedia.org>

This would break filtering incoming mail by the criterion "sender address" and isn't desirable.

Is there any situation in which simply filtering for @phabricator.wikimedia.org is not suitable or not supported by the filter software?

Using a plus sign as a sub-addressing tag might work in some MTAs and MUAs though (RFC 5233, no idea about Gmail).

You mean like this?

[username] <no-reply+[userid]@phabricator.wikimedia.org>

What do you mean by "works"? That different usernames are not collapsed in conversation view? That filtering for no-reply@phabricator.wikimedia.org will match no-reply+foo@phabricator.wikimedia.org?

In T77681#944054, @Tgr wrote:

Is there any situation in which simply filtering for @phabricator.wikimedia.org is not suitable or not supported by the filter software?

True - I'm not aware of any other local parts currently used (locally we've only used PhabAnnounce@phabricator.w.o so far but that was a bit hackish).

Using a plus sign as a sub-addressing tag might work in some MTAs and MUAs though (RFC 5233, no idea about Gmail).

You mean like this?

[username] <no-reply+[userid]@phabricator.wikimedia.org>

What do you mean by "works"? That different usernames are not collapsed in conversation view?

I don't know. I neither use the Gmail web interface nor some mail client that allows a "conversation view" and I don't know their implementations.

That filtering for no-reply@phabricator.wikimedia.org will match no-reply+foo@phabricator.wikimedia.org?

It should not. But again depends on the filter implementation of your application.

In any case I personally don't plan to investigate providing requested functionality locally. Plus I'm not convinced that this is a good approach at all so I'd decline this.
If you feel strongly about this feel free to talk to upstream (on your own risk) to get some more input.

Qgil claimed this task.

I'm not convinced that this is a good approach at all so I'd decline this.

I agree. The current behavior is ok, and upstream maintainers have defended the current way it works in some discussions, basing their argument precisely in consistent email threads. They know well the topic, so if you want to clone this report upstream, they will probably have an opinion about it.

Declining.