Page MenuHomePhabricator
Create Task
Maniphest T77955

Direct links to Phabricator bugs in gerrit commit messages result in messed up markup
Closed, DuplicatePublic
Actions

Description

This bug is more or less useless now that I know that gerrit automatically has Phabricator bug-linking already, but since it might affect others who are oblivious to this knowledge, I figured it was worth reporting.

Placing the URL for a Phabricator bug in the commit message of a gerrit patch results in some very weird markup due to what appears to be attempted replacement of the Txxxxx section of the link.

Reproduction steps:
Create a gerrit patch with a link to a Phabricator bug in the commit message.

Example:
https://gerrit.wikimedia.org/r/#/c/178420/

Sorry if I've added this to the wrong project/group.

Related Objects

Event Timeline

• jhobs created this task.Dec 9 2014, 3:36 AM
• jhobs raised the priority of this task from to Needs Triage.
• jhobs updated the task description. (Show Details)
• jhobs added projects: Gerrit, Phabricator.
• jhobs changed Security from none to None.
• jhobs subscribed.
jeremyb subscribed.Dec 9 2014, 3:57 AM
Qgil triaged this task as Lowest priority.Dec 9 2014, 1:03 PM
Qgil added subscribers: QChris, Qgil.

https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Phabricator explains how Phabricator tasks should be linked. Pasting full URLs of Phabricator tasks conflicts with these guidelines so, in my opinion, that would be the first problem to solve.

Proposing Invalid resolution for this task, but @QChris is the right person to decide.

Qgil moved this task from To Triage to Need discussion on the Phabricator board.Dec 9 2014, 1:03 PM
Aklapper closed this task as a duplicate of T75997: Full Phabricator links are being expanded weirdly in gerrit.Dec 9 2014, 2:34 PM

Hi @jhobs. Thanks for taking the time to report this!
This particular problem has already been reported into our bug tracking system as T75997, but please feel free to report any further issues you find. Further handling of the reported issue happens in T75997.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL