Instance 1:
I got an email today that this commit was made on my behalf, however I did not write the code or commit it. Apparently it was made on June 29, but it says on my profile that the activity was on December 9.
I'm guessing that, because the usernames were matching, it thought I was that user.
Instance 2:
https://phabricator.wikimedia.org/rODCVbb2765dcfe11 for @CharlieTheCabbie
Strange. I would assume that the check is done against email address and not username? This is the original changeset in Gerrit: https://gerrit.wikimedia.org/r/#/c/141266/ . There you can see the email address of DavisNT. For some strange reason, could that be the same address that you have now?
Thanks for noticing the 404. I don't know whether it is intended, but it happens to partially solve T75715 while we figure out what to do there.
No, neither the username nor email matched mine (davis_at_daviskr.com) or any I have used in the past. Maybe DavisNT had changed his name from DavisKR to DavisNT? This is very strange.
This is expected. For committer a <b@c.com>, we follow this logic:
Specifically, the name on the commit ("Davis") matches the real name on your account ("Davis"). In the common case these strings are more like "Evan Priestley" vs "Evan Priestley", which is a very high-confidence match for most installs.
You can work around this by choosing a different "real name" for your account, I suppose.
See also https://secure.phabricator.com/T1731
Oh -- the "Real Name" field on this install has been renamed to "Also Known As", which may generally reduce match strength. In the upstream, this field is called "Real Name".
If you want to disable this behavior, it lives here and could safely be commented out:
There's also an event listener you can use to override this behavior without forking, but we generally discourage using event listeners now (other approaches have superseded them for most customization/hooks):
https://secure.phabricator.com/book/phabricator/article/events/#diffusion-lookup-user
The scripts/repository/reparse.php --message <commit> script can fix bad user identifications after the initial import.
Like the OP on this bug, I got an email about 15 minutes ago, stating that this patch was committed in my name, and authored by myself. The thing is, it wasn't. I couldn't code if my life depended on it. I hope something can be resolved to stop this happening - I don't want to be blamed for something if it goes toes up in my name :)
@Daviskr I made this issue a bit more general to link two cases and provide more context. We still need to tackle this.
It would also be nice if we could see the original commit details somewhere, à la https://git.wikimedia.org/commit/mediawiki%2Fcore/987a860df428e3c70fd81c404f1f7a300345dc48 or at worst https://git.wikimedia.org/patch/mediawiki%2Fcore/987a860df428e3c70fd81c404f1f7a300345dc48
Not understanding. Are not these from the description what you mean?
https://phabricator.wikimedia.org/rEADT7b77eb7970283304554888e2bcf88bcda1f57f0e
https://phabricator.wikimedia.org/rODCVbb2765dcfe11
Not understanding. Are not these from the description what you mean?
I mean that in diffusion so far I only found diffusion's own interpretation of the metadata, but no way to see the metadata itself, for instance the email address (which would allow the user to double check usernames).
Given that ^ (unable to see the original metadata in Diffusion) we should probably do what Evan suggested:
Independently, we could prioritize this upstream task: https://secure.phabricator.com/T1731 ("Allow users to set their VCS names"), which would address part of the problem. Only part because if no one had their vcs-name set to this email, then David would still be getting associated with it if we don't comment out the function as described int he previous comment.
Does this still need to be high priority? There has not been a discussion on here since december 2015.
This should finally be resolved. Most miss-attributed commits have been cleaned up by running bin/repository rebuild-identities. Any remaining can be re-assigned by a phabricator admin. If you are aware of any please reopen or ping me on irc and I'll fix it up.