Page MenuHomePhabricator
Create Task
Maniphest T77971

redirect.py does not support Wikibase redirects
Closed, ResolvedPublic
Actions

Description

P132 has a paste of log and error.

Wikidata policy now requires redirect after merge (no delete), so this should be fixed asap.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
set_redirect_target method for ItemPage objectspywikibot/coremaster+51 -0
Customize query in gerrit

Related Objects

Event Timeline

revi created this task.Dec 9 2014, 9:53 AM
revi raised the priority of this task from to Needs Triage.
revi triaged this task as High priority.
revi updated the task description. (Show Details)
revi added projects: Pywikibot, Pywikibot-redirect.py.
revi changed Security from none to None.
revi updated the task description. (Show Details)
revi subscribed.
Ladsgroup claimed this task.Dec 9 2014, 3:28 PM
Ladsgroup added a subtask: T78094: ItemPage should support redirects.Dec 9 2014, 11:54 PM
revi mentioned this in T78094: ItemPage should support redirects.Dec 10 2014, 5:30 AM
Ricordisamoa closed subtask T78094: ItemPage should support redirects as Resolved.Dec 10 2014, 6:52 AM
Ricordisamoa renamed this task from redirect.py does not support wikidata redirect item to redirect.py does not support Wikibase redirects.Dec 10 2014, 6:55 AM
Ricordisamoa removed a subtask: T78094: ItemPage should support redirects.
Ricordisamoa subscribed.Dec 10 2014, 11:45 AM

RedirectRobot.fix_1_double_redirect() searches for APISite.redirectRegex() in the page content, which of course doesn't work for Wikibase.

gerritbot added a project: Patch-For-Review.Dec 19 2014, 10:43 PM

Change 181195 had a related patch set uploaded (by Ladsgroup):
Temp. workaround for Bug: T77971

https://gerrit.wikimedia.org/r/181195

Patch-For-Review

gerritbot subscribed.Feb 9 2015, 7:34 AM

Change 181195 abandoned by Ladsgroup:
Temp. workaround for Bug: T77971

Reason:
With I767dd8 no need for this

https://gerrit.wikimedia.org/r/181195

jayvdb subscribed.Feb 10 2015, 8:57 PM

So, is this fixed now?

Ricordisamoa added a comment.EditedFeb 11 2015, 5:50 AM
In T77971#1029007, @jayvdb wrote:

So, is this fixed now?

No, it isn't. ItemPage does not have a set_redirect_target() method yet.

Ricordisamoa removed a project: Patch-For-Review.Feb 11 2015, 5:50 AM
gerritbot added a comment.Apr 22 2015, 11:34 AM

Change 190160 had a related patch set uploaded (by Ladsgroup):
set_redirect_target method for ItemPage objects

https://gerrit.wikimedia.org/r/190160

gerritbot added a project: Patch-For-Review.Apr 22 2015, 11:34 AM
gerritbot added a comment.May 11 2015, 6:55 PM

Change 190160 merged by jenkins-bot:
set_redirect_target method for ItemPage objects

https://gerrit.wikimedia.org/r/190160

Ladsgroup mentioned this in rPWBCc8df4ec80235: set_redirect_target method for ItemPage objects.May 11 2015, 6:55 PM
Ladsgroup lowered the priority of this task from High to Low.May 31 2015, 4:58 PM
Ladsgroup removed a project: Patch-For-Review.

Another patch is needed to add support of set_redirect_target for items in Wikidata. I will write it

Ladsgroup closed this task as Resolved.Aug 10 2015, 9:55 AM
• Phabricator_maintenance added a project: User-Ladsgroup.Aug 12 2016, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits