See screenshot:
(A problem in Apex too, but feels worse in MW.)
Jdforrester-WMF | |
Dec 9 2014, 8:09 PM |
F28262: no_clash_with_round_corners.png | |
Jan 12 2015, 10:51 PM |
F20251: Screen_Shot_2014-12-09_at_11.24.10.png | |
Dec 9 2014, 8:09 PM |
See screenshot:
(A problem in Apex too, but feels worse in MW.)
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Fix styling of MWCategoryWidget to match MW theme | mediawiki/extensions/VisualEditor | master | +10 -86 |
Nothing in VisualEditor or the new OOjs UI front-end has anything to do with MediaWiki UI, which was built as an ad hoc provision for systems not yet using OOjs UI.
Whatever you call it, (nearly) everything else in VE is using the standard form style first used in MediaWiki UI, while this is using something different and therefore looks weird and silly.
(The category selector really should be implemented using the kind of multiselect widget used here by Phabricator for lists of projects or people subscribed to the task, etc. (Phab calls them "tokenizers", which if you ask me is a pretty silly name.) Some of MediaWiki's forms also use something similar, e.g. on https://wikitech.wikimedia.org/wiki/Special:NovaSecurityGroup (alas, you need to be logged in to view that page, apparently).)
Change 183486 had a related patch set uploaded (by Esanders):
Fix styling of MWCategoryWidget to match MW theme
The rounded corners are just left over the from Apex skin where they looked less out of place. Fixed in patch above.
Change 183486 merged by jenkins-bot:
Fix styling of MWCategoryWidget to match MW theme
@Ricordisamoa, since you subscribed the same minute that @Jdforrester-WMF resolved this (and removed your subscription in the process), I'm assuming it was just Phabricator's lack of conflict detection. See T78236
I checked the resolution to this bug on deployment-prep and found that to close the category popup you actually have to click outside the button which opened it. But I would expect that clicking the button again (while the popup is still open) would close it.