Page MenuHomePhabricator

Extra space before the start of the citation/template (not multiple transclusion) dialog contents
Closed, ResolvedPublic

Description

See screenshot:

Event Timeline

Jdforrester-WMF raised the priority of this task from to Needs Triage.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF changed Security from none to None.
Jdforrester-WMF added a subscriber: Jdforrester-WMF.
Jdforrester-WMF triaged this task as High priority.Dec 9 2014, 8:33 PM

Seems the same in Apex to me. It's a hidden oo-ui-labelElement-label containing the template name, above the template page description.

Krenair renamed this task from Vertical spacer before the start of the citation dialog contents is too big in VisualEditor when using the OOjs UI MediaWiki theme to Extra space before the start of the citation dialog contents.Dec 11 2014, 8:10 PM
Krenair removed a project: OOUI.
Krenair renamed this task from Extra space before the start of the citation dialog contents to Extra space before the start of the citation/template (not multiple transclusion) dialog contents.Dec 11 2014, 9:49 PM
Krenair claimed this task.

It's because of how we try to hide the template page label on single transclusion dialogs (e.g. templates, citations): https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/45518019eb8b668df42a5b3886be8031f578fdee/modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css#L55-L61

We use all of that instead of display:none so we can fade it out (see transition lines above).

Just need to work out why it still takes up room.

Change 179551 had a related patch set uploaded (by Alex Monk):
Hide extra space at the top of the single transclusion dialogs

https://gerrit.wikimedia.org/r/179551

Patch-For-Review

Jdforrester-WMF lowered the priority of this task from High to Low.Jan 15 2015, 12:15 AM

The transitions are currently broken, and I think a bit OTT given we are transitioning the width of the entire dialog. I suggest just display:none-ing them.

Change 179551 merged by jenkins-bot:
Hide extra space at the top of the single transclusion dialogs

https://gerrit.wikimedia.org/r/179551

Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Feb 3 2015, 12:56 AM