Maniphest T78052

Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Dec 9 2014, 8:19 PM

Tags

Referenced Files

	F20933: Screen_Shot_2014-12-11_at_17.20.09.png
	Dec 12 2014, 1:20 AM

	F20272: Screen_Shot_2014-12-09_at_11.20.55.png
	Dec 9 2014, 8:19 PM

Subscribers

Jdforrester-WMF

Description

See screenshot:

Screen_Shot_2014-12-09_at_11.20.55.png (514×530 px, 24 KB)

Details

	Subject	Repo	Branch	Lines +/-
	TextInputWidget: Set vertical-align: middle, like buttons	oojs/ui	master	+2 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
		Open		None	T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
		Resolved		matmarex	T74715 Convert some MW core special pages to OOUI
		Resolved		• TrevorParscal	T74714 Provide the OOUI PHP module inside MW core
		Resolved		Jdforrester-WMF	T78054 Switch MediaWiki core's use of OOjs UI to use the MediaWiki theme, not Apex
		Resolved		matmarex	T78052 Vertical alignment of the "add template" button and the search box is incorrect in template dialog in VisualEditor when using the OOjs UI MediaWiki theme

Event Timeline

Jdforrester-WMF created this task.Dec 9 2014, 8:19 PM

Jdforrester-WMF raised the priority of this task from to Needs Triage.

Jdforrester-WMF updated the task description. (Show Details)

Jdforrester-WMF added projects: VisualEditor, VisualEditor-MediaWiki-Templates, OOUI.

Jdforrester-WMF changed Security from none to None.

Jdforrester-WMF added a project: VisualEditor-MediaWiki.

Jdforrester-WMF subscribed.

Jdforrester-WMF triaged this task as High priority.Dec 9 2014, 8:33 PM

Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.Dec 9 2014, 8:37 PM

Liuxinyu970226 subscribed.Dec 11 2014, 4:15 AM

Jdforrester-WMF assigned this task to matmarex.Dec 11 2014, 10:21 PM

Change 179339 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Set vertical-align: middle, like buttons

https://gerrit.wikimedia.org/r/179339

Patch-For-Review

Above patch fixes this:

Screen_Shot_2014-12-11_at_17.20.09.png (514×516 px, 19 KB)

Jdforrester-WMF closed this task as Resolved.Dec 12 2014, 7:28 PM

Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).

Change 179339 merged by jenkins-bot:
TextInputWidget: Set vertical-align: middle, like buttons

https://gerrit.wikimedia.org/r/179339

Liuxinyu970226 unsubscribed.Dec 13 2014, 6:57 AM

Jdforrester-WMF removed a project: Patch-For-Review.Dec 15 2014, 9:22 PM

Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 7 2015, 9:17 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:34 PM

Jdforrester-WMF edited a custom field.Jan 23 2015, 11:55 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM

matmarex mentioned this in rGOJUa9475fe3780e: TextInputWidget: Set vertical-align: middle, like buttons.Mar 3 2015, 7:49 PM

Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Mar 26 2015, 9:00 PM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:32 PM