Page MenuHomePhabricator

Image viewer footer is not correctly anchored, obscures lowest / bottom part of the image
Closed, ResolvedPublic

Description

Upstream: https://secure.phabricator.com/T6794#88229

when viewing images in the maniphest image viewer long images which require scrolling cause the view footer to move and obscure the image. can be tested by opening image viewer on image in this comment https://phabricator.wikimedia.org/T67079#688253

Event Timeline

Jaredzimmerman-WMF raised the priority of this task from to High.
Jaredzimmerman-WMF updated the task description. (Show Details)
Jaredzimmerman-WMF changed Security from none to None.

Screenshot_2014-12-09_14.13.47.png (606×2 px, 286 KB)

I can only reproduce the problem with less than 500px height in Firefox 34 with the given example.
What's your browser window height and your browser?

Aklapper renamed this task from Image viewer footer is not correctly anchored to Image viewer footer is not correctly anchored, obscures lowest part of the image.Dec 10 2014, 4:55 AM
Aklapper lowered the priority of this task from High to Low.

For me...

Firefox fits image to page and there is no scroll.

Chrome does provide scroll and the Download bar does eat a few pixel but is not as bad as what Jared shows.

Screenshot_from_2014-12-10_13:18:52.png (900×1 px, 196 KB)

A minor detail, but there is something fishy indeed.

Frequently we will be uploading very long assets (mobile designs which span multiple "screens" in length) this is not particular to WMF so anyone else using phab for mobile work will likely run into this.

my browsers was Chrome 40.0.2214.10 beta (64-bit)

Can you test this problem in Chrome Canary (v41) Mac, please? See https://secure.phabricator.com/T6794#88229

Aklapper renamed this task from Image viewer footer is not correctly anchored, obscures lowest part of the image to Image viewer footer is not correctly anchored, obscures lowest / bottom part of the image.Jan 24 2015, 9:57 PM
Aklapper added a subscriber: FriedhelmW.

Also happening on Firefox according to dup

According to upstream, this happens in Chrome 40 and it is fixed in Chrome 41. They don't intend to fix it in 40. Should we consider this fixed or declined?

Hmm, in that case T87515 would not be a dup. I'd like to retest that once I can get hands on Chrome 41 to test

This task is about Phabricator's media viewer. T89631 is about MediaWiki's media viewer.

https://secure.phabricator.com/T6794 has been closed as resolved (in Chrome 41, which is in production now). @Jaredzimmerman-WMF, do you think we can resolve here as well?