See screenshot (zoomed in for effect):
This looks like a rendering bug, but is actually intentional. Could we change the design to be less odd?
| Jdforrester-WMF | |
| Dec 9 2014, 10:43 PM |
| F27624: pasted_file | |
| Jan 10 2015, 9:53 PM |
| F26645: Screenshot_2015-01-05_11.32.52.png | |
| Jan 5 2015, 7:34 PM |
| F20310: Screen_Shot_2014-12-09_at_14.42.48.png | |
| Dec 9 2014, 10:43 PM |
See screenshot (zoomed in for effect):
This looks like a rendering bug, but is actually intentional. Could we change the design to be less odd?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| MediaWiki Theme: Adjust toolbar popups' border and shadows | oojs/ui | master | +4 -2 |
Hey May, I don't think the overlap of the shadow and the border is intended, can you confirm?
The grey (thick) shadow at the bottom of the dropdown (see screenshot in first post) overlaps with the (thin) border that goes around the dropdown on all 4 sides. To me it looks like the shadow should be moved down or up to avoid overlapping with the border (or the bottom border removed).
This question isn't about colors, though, but about the alignment/positioning of the shadow relative to the border. Right now the "inner shadow" is neither "inner" nor "outer" because it extends across the thin line around the box, so it's both inside and outside the box. From the image you posted (and your use of the word "inner") it seems like you want it to be on the inside, but in that picture the shadow also overlaps with the line and goes beyond it a little bit.
This is what we intended to have:
Inner shadow should be 3px
Box outline 1px
(Bottom) Outer shadow 1px
Change 184194 had a related patch set uploaded (by Bartosz Dziewoński):
MediaWiki Theme: Adjust toolbar popups' border and shadows
I don't like this very much, to be honest, but it's better than the current one. Screenshot below also includes rounded corners, which the patch above also adds, to match everything else and the mockup above.
Change 184194 merged by jenkins-bot:
MediaWiki Theme: Adjust toolbar popups' border and shadows
Verified in betalabs on Chrome, Safari - shadow does not overlap the border; the corners are rounded.