Page MenuHomePhabricator

Toolbars should have a heavy shadow on their bottom in the MediaWiki theme
Closed, ResolvedPublic

Description

toolbar--02.png (785×1 px, 401 KB)

4 pixel line under the toolbar
black at 15% opacity

Event Timeline

Jdforrester-WMF raised the priority of this task from to Medium.
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF changed Security from none to None.

Got any of these mockups? Asking because "shadows" in the MediaWiki theme usually look extremely unlike real shadows.

Actually, these are implemented to spec.

This is a menu example in the UI graphics provided to create this theme. This is the most recent version of the file as of today:

Screen_Shot_2014-12-11_at_11.58.06_AM.png (1×1 px, 93 KB)

Thanks Kaity! Let's do this then.

So in context, it's supposed to look like this? I can't quite tell from this mockup if the line is supposed to reach screen edges or not.

pasted_file (364×1 px, 46 KB)

Bartosz, I think you have it right - unfortunately the mockup is based on a hypothetical skin that doesn't have a line on the left so it's unclear.

Change 179221 had a related patch set uploaded (by Bartosz Dziewoński):
MediaWiki theme: Update toolbar design

https://gerrit.wikimedia.org/r/179221

Patch-For-Review

Change 179221 merged by jenkins-bot:
MediaWiki theme: Add thematic border to the bottom of toolbars

https://gerrit.wikimedia.org/r/179221