Page MenuHomePhabricator
Create Task
Maniphest T78156

[Task] Cache wbsearchentities responses for short prefixes
Closed, DeclinedPublic
Actions

Description

We use prefix searches on the wb_terms table to show type-ahead suggestions in the entity selector widget. These queries are very slow for short prefixes (three or less characters takes about 15 seconds on the live cluster currently).

We should cache the results for short prefixes in memcached (per language). The actual result shown to the user is around ten entries long, so cache entries would be small. (we could be "randomized put" to approximate LRU behavior).

Note that slow queries may time out. In such a case, we should cache an empty result set, to avoid issuing the same expensive/slow query again.

When T86530 is implemented this task is obsolete.

Details

SubjectRepoBranchLines +/-
Cache type ahead results for short prefixes.mediawiki/extensions/Wikibasemaster+47 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

daniel created this task.Dec 10 2014, 4:27 PM
daniel raised the priority of this task from to Needs Triage.
daniel updated the task description. (Show Details)
daniel added projects: MediaWiki-extensions-WikibaseRepository, Performance Issue.
daniel changed Security from none to None.
daniel added subscribers: daniel, JanZerebecki, • Manybubbles.
daniel triaged this task as High priority.Dec 10 2014, 4:44 PM
Lydia_Pintscher added a project: Wikidata.Dec 11 2014, 10:37 AM
gerritbot added a project: Patch-For-Review.Dec 15 2014, 2:19 PM

Change 179914 had a related patch set uploaded (by Daniel Kinzler):
Cache type ahead results for short prefixes.

https://gerrit.wikimedia.org/r/179914

Patch-For-Review

daniel renamed this task from Cache responses for label prefix searches for short prefixes. to Cache wbsearchentities responses for for short prefixes..Dec 15 2014, 2:23 PM
Lydia_Pintscher renamed this task from Cache wbsearchentities responses for for short prefixes. to Cache wbsearchentities responses for short prefixes.Dec 15 2014, 2:50 PM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Dec 28 2014, 6:03 PM
Addshore subscribed.Jun 15 2015, 3:36 PM
• Jonas renamed this task from Cache wbsearchentities responses for short prefixes to [Task] Cache wbsearchentities responses for short prefixes.Sep 10 2015, 7:38 PM
gerritbot subscribed.Sep 24 2015, 1:32 PM

Change 179914 abandoned by Daniel Kinzler:
Cache type ahead results for short prefixes.

Reason:
Jan suggested that it would make more sense to have the responses cached in varnish. We'd just have to send the corresponding http headers.

https://gerrit.wikimedia.org/r/179914

daniel added a comment.Sep 24 2015, 1:32 PM
This comment was removed by daniel.
Lydia_Pintscher removed a project: Patch-For-Review.Sep 24 2015, 1:45 PM
JanZerebecki added a comment.Sep 24 2015, 1:52 PM

No idea if this would actually work. Need to check if our varnishes are configured to respect the cache headers on api requests. Need to check if the browser usually keeps the connection open for long enough. Need to check if varnish keeps the connection open when the browser closes it.

JanZerebecki updated the task description. (Show Details)Sep 24 2015, 1:58 PM
matej_suchanek added a parent task: T46529: Wikidata search problems (tracking).Nov 24 2017, 6:15 PM
Liuxinyu970226 subscribed.Nov 30 2017, 11:17 AM
Addshore moved this task from ready to go to needs discussion or investigation on the Wikidata board.Nov 13 2018, 1:48 PM

Moving to needs investigation based on T78156#1670642

Addshore added a project: [DEPRECATED] wdwb-tech.Nov 13 2018, 1:48 PM
Addshore moved this task from needs discussion or investigation to in progress on the Wikidata board.Jun 21 2019, 11:30 PM
Addshore moved this task from in progress to needs discussion or investigation on the Wikidata board.Jun 22 2019, 10:38 PM
Addshore moved this task from Inbox to Research on the [DEPRECATED] wdwb-tech board.Mar 5 2021, 12:11 PM
Addshore moved this task from Research to Investigate & Discuss on the [DEPRECATED] wdwb-tech board.Jul 16 2021, 8:39 AM
Addshore closed this task as Declined.Jul 16 2021, 8:53 AM

Closing as this ticket mainly focuses on the wikidata usecase, which now uses elastic search.

More than happy to happy to have something else opened for other reasons etc, but this one doesnt need to happen now for the reasons described in the ticket.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL