Page MenuHomePhabricator
Create Task
Maniphest T78200

Flow replies get 503 fatal error on beta labs from ConfirmEdit shouldCheck
Closed, ResolvedPublic
Actions

Description

As far as we can tell, this applies to Flow and only to Flow.

Attempt to save a topic at http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA. Result is a red error "An error occurred while contacting the server." and js console shows a 503.

In the logs we find:

[proxy_fcgi:error] [pid 19052] (70014)End of file found: [client 10.68.16.16:4302] AH01075: Error dispatching request to :, referer: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA

No services other than Flow seem to be affected.

Screen_Shot_2014-12-10_at_3.14.18_PM.png (1×1 px, 283 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update ConfirmEdit integration to match mastermediawiki/extensions/Flowmaster+34 -5
Customize query in gerrit

Revisions and Commits

rEFLW extension-Flow
rEFLW7ac8461c3d60 Update ConfirmEdit integration to match master
rMEXT MediaWiki Extensions
rMEXTa20c4795c0d7 Updated mediawiki/extensions Project: mediawiki/extensions/Flow…

Event Timeline

• Cmcmahon created this task.Dec 10 2014, 10:17 PM
• Cmcmahon raised the priority of this task from to Unbreak Now!.
• Cmcmahon updated the task description. (Show Details)
• Cmcmahon added a project: StructuredDiscussions.
• Cmcmahon changed Security from none to None.
• Cmcmahon added subscribers: • Cmcmahon, bd808.
• Spage subscribed.Dec 10 2014, 10:40 PM

https://gerrit.wikimedia.org/r/#/c/177746/ changed ConfirmEdit's shouldCheck() method signature to specify a WikiPage instead of an untyped editPage parameter. Now Flow's call to shouldCheck() when you reply now gets a

Fatal error: Argument 1 passed to SimpleCaptcha::shouldCheck() must be an instance of WikiPage, 
 EditPage given in /srv/mediawiki/php-master/extensions/ConfirmEdit/Captcha.php on line 368

in hhvm.log

• Spage renamed this task from Flow seems to cause universal 503 on beta labs to Flow replies get 503 fatal error on beta labs from ConfirmEdit shouldCheck.Dec 10 2014, 10:41 PM
• Spage updated the task description. (Show Details)
• Spage added a project: ConfirmEdit (CAPTCHA extension).
• Spage added subscribers: EBernhardson, tstarling.
gerritbot added a project: Patch-For-Review.Dec 10 2014, 10:43 PM

Change 178988 had a related patch set uploaded (by EBernhardson):
Update ConfirmEdit integration to match master

https://gerrit.wikimedia.org/r/178988

Patch-For-Review

gerritbot added a comment.Dec 11 2014, 7:42 AM

Change 178988 merged by jenkins-bot:
Update ConfirmEdit integration to match master

https://gerrit.wikimedia.org/r/178988

EBernhardson closed this task as Resolved.Dec 11 2014, 7:43 AM
EBernhardson added a commit: rEFLW7ac8461c3d60: Update ConfirmEdit integration to match master.

Closed by commit rEFLW7ac8461c3d60.

Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
Diffusion added a commit: rMEXTa20c4795c0d7: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 4:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits