Page MenuHomePhabricator

Flow replies get 503 fatal error on beta labs from ConfirmEdit shouldCheck
Closed, ResolvedPublic

Description

As far as we can tell, this applies to Flow and only to Flow.

Attempt to save a topic at http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA. Result is a red error "An error occurred while contacting the server." and js console shows a 503.

In the logs we find:

[proxy_fcgi:error] [pid 19052] (70014)End of file found: [client 10.68.16.16:4302] AH01075: Error dispatching request to :, referer: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA

No services other than Flow seem to be affected.

Event Timeline

Cmcmahon raised the priority of this task from to Unbreak Now!.
Cmcmahon updated the task description. (Show Details)
Cmcmahon changed Security from none to None.
Cmcmahon added subscribers: Cmcmahon, bd808.

https://gerrit.wikimedia.org/r/#/c/177746/ changed ConfirmEdit's shouldCheck() method signature to specify a WikiPage instead of an untyped editPage parameter. Now Flow's call to shouldCheck() when you reply now gets a

Fatal error: Argument 1 passed to SimpleCaptcha::shouldCheck() must be an instance of WikiPage, 
 EditPage given in /srv/mediawiki/php-master/extensions/ConfirmEdit/Captcha.php on line 368

in hhvm.log

Spage renamed this task from Flow seems to cause universal 503 on beta labs to Flow replies get 503 fatal error on beta labs from ConfirmEdit shouldCheck.Dec 10 2014, 10:41 PM
Spage updated the task description. (Show Details)
Spage added subscribers: EBernhardson, tstarling.

Change 178988 had a related patch set uploaded (by EBernhardson):
Update ConfirmEdit integration to match master

https://gerrit.wikimedia.org/r/178988

Patch-For-Review

Change 178988 merged by jenkins-bot:
Update ConfirmEdit integration to match master

https://gerrit.wikimedia.org/r/178988