Page MenuHomePhabricator

Phabricator Maniphest Subscribe/Unsubscribe action has oddly different font treatment
Closed, ResolvedPublic

Description

For some reason the Subscribe/Unsubscribe action in Phabricator Maniphest is getting -webkit-font-smoothing: antialiased; while its nearby siblings such as Edit Task or Merge Duplicates In are not. This is a bit weird.

Event Timeline

MZMcBride raised the priority of this task from to Needs Triage.
MZMcBride updated the task description. (Show Details)
MZMcBride changed Security from none to None.
MZMcBride added a subscriber: MZMcBride.
Qgil triaged this task as Lowest priority.Dec 11 2014, 8:32 AM
Qgil added a subscriber: Qgil.

Interesting. Do you want to file this one upstream directly? Looks like one of those oversights that they fix in a whim.

Mmm... isn't this fixed now?

In T78235#840803, @Qgil wrote:

Interesting. Do you want to file this one upstream directly? Looks like one of those oversights that they fix in a whim.

At the moment I have pretty mixed feelings toward upstream, so no, I don't want to file an upstream task right now. Anyone else is welcome to, of course.

In T78235#845624, @Qgil wrote:

Mmm... isn't this fixed now?

Nope. (I'm not sure what would've changed between now and December 11 when I filed this task.)

Looking at the "Computed" tab for CSS in Google Chrome 39 for the "Unsubscribe" item, it's still applied to "button, a.button" which matches only for this element in the list.

I'm not sure what would've changed between now and December 11

We pulled recent code from upstream (T77082) which made T635 vanish.

Is this problem still there? If it is, I will report it blindly. I still see Subscribe/Unsubscribe just like the rest of buttons, and I'm getting lost in the sea of CSS Computes parameters.

Aklapper claimed this task.

Good catch. Fixed upstream in e3594e0a618db966cc33201eb020bc96820c50b6 on Feb 15, 2015 ("Restrict font-smoothing to actual buttons").