Page MenuHomePhabricator

Adding a blocker results in "edited tasks, added: 1; removed: 1"?
Closed, ResolvedPublic

Description

Uh? What's that supposed to mean? https://phabricator.wikimedia.org/T911#836398

Event Timeline

Nemo_bis raised the priority of this task from to Needs Triage.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a project: Phabricator.
Nemo_bis changed Security from none to None.
Nemo_bis added a subscriber: Nemo_bis.
Aklapper triaged this task as Lowest priority.Dec 11 2014, 10:01 AM

This message comes when adding one or more tasks while removing one or more tasks. I'm not happy about it either. The usefulness of this details only comes with the detail of the tasks involved.

We should probably upstream this.

We should probably upstream this.

Do you volunteer? :) There are currently 15 "ready to go" tasks, the upstreamers probably need help.

Is there consensus for this to be upstreamed for Wikimedia? I think it could be upstreamed independently...

I also think this task can be upstreamed independently. I believe it is a "regression". Before you would see both tasks mentioned.

Upstream comment by Evan:

To resolve this:

  • Convert TYPE_TASK_DEPENDS_ON_TASK and TYPE_TASK_DEPENDED_ON_BY_TASK to modern EdgeType classes (see https://secure.phabricator.com/D9839 for an example).
  • Provide appropriate get...String() implementations.
  • Implement English translations in PhabricatorBaseEnglishTranslation.
Aklapper raised the priority of this task from Lowest to Low.Dec 16 2014, 12:32 AM
Aklapper added a project: Phabricator.
Qgil claimed this task.

Resolved upstream thanks to a patch created by @Krenair. Thank you!