Page MenuHomePhabricator
Create Task
Maniphest T78300

[Task] Remove code and behavior sharing by inheritance in EntityTest
Closed, ResolvedPublic
Actions

Description

"EntityTest and ItemTest are now the worst rated classes in DataModel."

https://github.com/wmde/WikibaseDataModel/issues/172

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT124286 [Epic] Wikidata language support
 OpenNoneT76216 [Epic] Language fallback
 ResolvedBeneT78300 [Task] Remove code and behavior sharing by inheritance in EntityTest
 DeclinedBeneT98290 [Task] Remove deprecated methods from Entity and subtypes
 ResolvedBeneT104695 Deprecate Entity methods not in EntityDocument
 ResolvedBeneT78286 Add Label/Description/Alias interfaces
 ResolvedBeneT104895 [Story] Stop using deprecated methods of Entity
 ResolvedAddshoreT64188 Replace old serialization code in lib with datamodel serialization
 ResolvedLydia_PintscherT73170 [Story] Ensure feature parity of serialization based on WikibaseDataModelSerialization with what we do with WikibaseLib
 ResolvedJanZerebeckiT74183 New serialization code needs to support language fallback
 ResolvedJanZerebeckiT75886 Fix Wikibase Serialization Tests
 OpenNoneT73512 [Task] DataModelSerialization: create filter by language that can be applied to objects before passing to serialization
 InvalidNoneT76251 find or create Transliterator
 InvalidNoneT76252 create AcceptLanguageSet that is usable in DataModel
 DeclinedAddshoreT78653 DataModelSerialization: optionally (?!) group statements and snaks.
 ResolvedAddshoreT78651 Add integration tests that ensure compatibility
 ResolvedLydia_PintscherT78652 DataModelSerialization: Serializers to be used with the MediaWiki API need to inject meta-info like _indexTagNames, to allow XML output from API modules.
 ResolvedAddshoreT92970 Replace ApiResult::setRawMode use in EntityDataSerializationService
 ResolvedaudeT93353 Drop support for API style XML output from Special:EntityData
 OpenNoneT98039 Include incoming redirects in JSON representation of entities (tracking)
 ResolveddanielT96364 Create a PHP service interface for accessing entity redirects
 InvalidNoneT98317 [Story] Optionally include incoming redirects in the output of wbgetentities
 OpenNoneT98320 [Task] Create dump of entity redirects (JSON or n-triples)
 OpenNoneT98322 [Task] Include redirects in JSON output from Special:EntityData
 InvalidNoneT98850 [Task] DataModelSerialization: include the property data type in Property*Snaks.
InvalidNoneT98857 [Task] DataModelSerialization: option to force maps to lists, if needed
 InvalidNoneT98860 [Task] DataModelSerialization: always force maps to be represented as stdclass objects when generating JSON output.
 InvalidNoneT98861 [Task] DataModelSerialization: represent map order in JSON output
 InvalidNoneT98862 [Task] DataModelSerialization: allow injection of meta-data like the revision id
 DeclinedBeneT98863 DataModelSerialization: The serializer should allow marking specific parts of the data as "deleted".
 ResolvedBeneT104380 Release Wikibase DataModel Serialization 1.5
 OpenNoneT89005 [Story] JSON should (optionally) contain expanded/normalized values.
 OpenNoneT73992 [Story] JSON should (optionally) contain full URIs for referenced external entities
 ResolvedhooT95682 [Task] Add a new datatype for identifiers
 ResolvedTobi_WMDE_SWT88451 [Epic] Provide a mechanism for registering new data types.
 ResolveddanielT104329 [Task] Create central registry for datatypes
 ResolveddanielT110212 Manage ValueParsers based on central DataType registry
 ResolveddanielT110213 Manage ValueFormatters based on central DataType registry
 ResolveddanielT110214 [Task] Manage RDF mapping of data values based on central DataType registry
 ResolveddanielT112083 [Task] Allow RDF bindings for different data types to be registered dynamically.
 ResolveddanielT118499 [Task] Define RDF mappings per value type
 ResolveddanielT118497 [Task] Allow central datatype registry to also manage callbacks per value type.
 ResolvedaudeT120643 Adjust WikibaseQuality external validation for changes in data type registration
 ResolveddanielT118500 [Task] Split RDF mapping code into separate classes per type
 ResolveddanielT110215 Manage ValueValidators based on central DataType registry
 ResolvedBeneT95285 [Task] Record base URI for external identifiers in the wb_property_info table
 InvalidNoneT93747 [Story] Create infrastructure for optionally putting normalized values into JSON
 InvalidNoneT102835 [Task] Implement service for placing derived values in PropertyValueSnak objects in the data model before serialization
 InvalidNoneT102833 [Task] Implement serializer and unserializer for derived values in a PropertyValueSnak
 ResolvedAddshoreT102791 Implement ExtendedPropertyValueSnak
 InvalidNoneT102789 [Task] Unserializers should optionally allow derived data objects
 InvalidNoneT102788 [Task] Serializers should optionally fail when encountering derived data
 ResolveddanielT112547 [RFC] Decide on a mechanism for supporting derived values during serialization
 InvaliddanielT118860 [RFC] Use Role Object Pattern to represent derived data in the data model
 ResolveddanielT112550 [RFC] How to represent derived values in the data model, and allow for deferred deserialization
 ResolvedthiemowmdeT112893 [Task] Investigate how and where data model objects are instanciated in our code base
 DeclinedNoneT132443 [Task] Discuss design of (De)Serializer interfaces
 OpenNoneT76827 [Story] Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia
 ResolvedAddshoreT89234 Use datamodel serialization in Wikibase\Client\Scribunto\EntityAccessor
 ResolvedAddshoreT104180 Use datamodel serialization in Wikibase\Api\ResultBuilder
 ResolvedBeneT104183 Add Term Serializer & Deserializer
 ResolvedBeneT104182 Add TermList Serializer & Deserializer
 ResolvedBeneT104181 Add AliasGroup Serializer & Deserializer
 ResolvedAddshoreT106863 Deprecate and remove the ungroupedlist api option
 ResolveddanielT110177 [RFC] Add methods to EntityDocument
 ResolvedBeneT109581 Figure out what to do with Entity::isEmpty
 DeclinedBeneT78291 [Task] Remove deprecated term methods from Entity

Event Timeline

Lucie created this task.Dec 11 2014, 3:26 PM
Lucie raised the priority of this task from to Needs Triage.
Lucie updated the task description. (Show Details)
Lucie added projects: Wikibase-DataModel, Wikidata.
Lucie changed Security from none to None.
Lucie subscribed.
thiemowmde renamed this task from Remove code and behaviour sharing by inheritance in EntityTest to [Task] Remove code and behavior sharing by inheritance in EntityTest.Sep 10 2015, 4:08 PM
thiemowmde triaged this task as Lowest priority.
thiemowmde added a subtask: T98290: [Task] Remove deprecated methods from Entity and subtypes.
thiemowmde added subscribers: JeroenDeDauw, Bene.
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.Sep 10 2015, 9:51 PM
Bene closed subtask T98290: [Task] Remove deprecated methods from Entity and subtypes as Declined.Feb 12 2016, 5:07 PM
matej_suchanek closed this task as Resolved.Dec 8 2017, 4:07 PM
matej_suchanek assigned this task to Bene.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL