Page MenuHomePhabricator
Create Task
Maniphest T78330

[unplanned] Notifications box is not well located in RTL wikis
Closed, ResolvedPublic
Actions

Description

In RTL wikis (in vector skin), the notifications box is not well located. It can be fixed by changing the CSS property "right" in the class "mw-echo-overlay:before" from 193px to 230px. See the local fixing on the Hebrew Wikibooks.

Details

SubjectRepoBranchLines +/-
Fix the overlay chevron position for RTLmediawiki/extensions/Echomaster+10 -2
Customize query in gerrit

Related Objects

Event Timeline

Guycn2 created this task.Dec 11 2014, 8:14 PM
Guycn2 raised the priority of this task from to Needs Triage.
Guycn2 updated the task description. (Show Details)
Guycn2 changed Security from none to None.
Guycn2 updated the task description. (Show Details)
Guycn2 subscribed.
Krenair added a project: Notifications.Dec 11 2014, 8:45 PM
Krenair subscribed.

Do not file Phabricator reports without associating at least one project.

Guycn2 updated the task description. (Show Details)Dec 12 2014, 3:45 PM
Guycn2 updated the task description. (Show Details)
Guycn2 unsubscribed.
Guycn2 subscribed.
Guycn2 updated the task description. (Show Details)Dec 12 2014, 3:48 PM
Amire80 claimed this task.Jan 4 2015, 9:07 AM
Amire80 triaged this task as Medium priority.
Amire80 added a comment.Jan 4 2015, 9:13 AM

This happens in Monobook, too, so the workaround should be in Common.css and not Vector.css.

gerritbot added a project: Patch-For-Review.Jan 4 2015, 9:52 AM

Change 182658 had a related patch set uploaded (by Amire80):
Fix the overlay caret position for RTL

https://gerrit.wikimedia.org/r/182658

Patch-For-Review

Amire80 renamed this task from Notifications box is not well located in RTL wikis to [unplanned] Notifications box is not well located in RTL wikis.Jan 4 2015, 11:02 AM
Amire80 added a project: LE-Sprint-81.
Amire80 moved this task from Backlog to In Review on the LE-Sprint-81 board.
gerritbot added a comment.Jan 9 2015, 6:59 PM

Change 182658 merged by jenkins-bot:
Fix the overlay chevron position for RTL

https://gerrit.wikimedia.org/r/182658

Amire80 mentioned this in rECHO91847e96c619: Fix the overlay chevron position for RTL.Jan 9 2015, 6:59 PM
Amire80 closed this task as Resolved.Jan 9 2015, 7:07 PM
Amire80 added subscribers: matthiasmullie, EBernhardson.

@Guycn2, thanks for reporting.

@matthiasmullie, @EBernhardson, thanks for reviewing.

This is now fixed, and will deployed in a few days.

Amire80 moved this task from In Review to Done on the LE-Sprint-81 board.Jan 9 2015, 7:58 PM
Amire80 mentioned this in rMEXT26eb713cfa3e: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Mar 11 2015, 6:23 AM
RandomDSdevel awarded a token.Mar 29 2015, 10:15 PM
Aklapper added a project: RTL.Jun 2 2015, 2:20 PM
Restricted Application added projects: Collaboration-Team-Triage, I18n. · View Herald TranscriptJun 2 2015, 2:20 PM
• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Jun 2 2015, 4:27 PM
• Phabricator_maintenance removed a parent task: T2745: [DO NOT USE] RTL/bidirectional issues (tracking) [superseded by #RTL].Feb 22 2019, 1:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL