Page MenuHomePhabricator
Create Task
Maniphest T78336

"|" in Flickr description truncates it
Closed, ResolvedPublic
Actions

Description

See:

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UploadWizardmaster+47 -5Sanitize flickr descriptions before pre-filling
mediawiki/extensions/UploadWizardwmf/1.25wmf14+9 -9Revert "Sanitize | characters in descriptions"
mediawiki/extensions/UploadWizardwmf/1.25wmf15+9 -9Revert "Sanitize | characters in descriptions"
mediawiki/extensions/UploadWizardmaster+9 -9Revert "Sanitize | characters in descriptions"
mediawiki/extensions/UploadWizardmaster+9 -9Sanitize | characters in descriptions
Customize query in gerrit

Related Objects

Event Timeline

MarkTraceur created this task.Dec 11 2014, 9:24 PM
MarkTraceur claimed this task.
MarkTraceur raised the priority of this task from to Medium.
MarkTraceur updated the task description. (Show Details)
MarkTraceur added projects: Multimedia, UploadWizard.
MarkTraceur moved this task to Next up on the Multimedia board.
MarkTraceur changed Security from none to None.
MarkTraceur added a subscriber: MarkTraceur.
Ricordisamoa added a subscriber: Ricordisamoa.Dec 11 2014, 9:45 PM
MarkTraceur moved this task from Next up to Reviewed, needs improvements on the Multimedia board.Dec 22 2014, 5:22 PM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.
gerritbot added a project: Patch-For-Review.Dec 22 2014, 6:20 PM

Change 181425 had a related patch set uploaded (by MarkTraceur):
Sanitize | characters in descriptions

https://gerrit.wikimedia.org/r/181425

Patch-For-Review

Tgr moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 23 2014, 8:55 PM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 24 2014, 4:29 PM
Tgr moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 24 2014, 5:22 PM
MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 24 2014, 7:25 PM
Tgr moved this task from Needs code review to Ready for testing on the Multimedia board.Dec 31 2014, 7:46 AM
gerritbot added a comment.Dec 31 2014, 7:47 AM

Change 181425 merged by jenkins-bot:
Sanitize | characters in descriptions

https://gerrit.wikimedia.org/r/181425

MarkTraceur mentioned this in rEUWI154642f854c1: Sanitize | characters in descriptions.Dec 31 2014, 7:47 AM
Gilles closed this task as Resolved.Jan 14 2015, 3:49 PM
Gilles moved this task from Ready for testing to Doing on the Multimedia board.
Gilles added a subscriber: Gilles.
Tgr reopened this task as Open.Jan 16 2015, 7:37 PM
Tgr added a subscriber: Tgr.

This is causing major problems on Commons since it breaks templates included in the description.

Tgr raised the priority of this task from Medium to Unbreak Now!.Jan 16 2015, 7:37 PM

E.g. https://commons.wikimedia.org/w/index.php?title=File:Scouts_of_the_Japanese_Army.jpg&diff=146765421&oldid=146761665

gerritbot added a subscriber: gerritbot.Jan 16 2015, 7:40 PM

Change 185487 had a related patch set uploaded (by Gergő Tisza):
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185487

Patch-For-Review

gerritbot added a comment.Jan 16 2015, 7:46 PM

Change 185487 merged by jenkins-bot:
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185487

Tgr mentioned this in rEUWI8fd6040672e9: Revert "Sanitize | characters in descriptions".Jan 16 2015, 7:48 PM
gerritbot added a comment.Jan 16 2015, 7:58 PM

Change 185493 had a related patch set uploaded (by MarkTraceur):
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185493

Patch-For-Review

gerritbot added a comment.Jan 16 2015, 7:58 PM

Change 185494 had a related patch set uploaded (by MarkTraceur):
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185494

Patch-For-Review

gerritbot added a comment.Jan 16 2015, 8:09 PM

Change 185493 merged by MarkTraceur:
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185493

MarkTraceur mentioned this in rEUWId6a630f77e3a: Revert "Sanitize | characters in descriptions".Jan 16 2015, 8:09 PM
gerritbot added a comment.Jan 16 2015, 8:15 PM

Change 185494 merged by jenkins-bot:
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185494

MarkTraceur mentioned this in rEUWIb249060e21ef: Revert "Sanitize | characters in descriptions".Jan 16 2015, 8:16 PM
Tgr added a comment.Jan 17 2015, 12:23 AM

Reverted, backported. People put stuff like {{w|foo}} in descriptions, and that should continue to work. Seems hard to do without doing some lightweight wikitext parsing.

Ricordisamoa added a comment.Jan 17 2015, 12:36 AM

Escaping | as {{!}} (like @MarkTraceur did) should do the job, since the latter is a core parser function.

Tgr added a comment.Jan 17 2015, 12:48 AM
In T78336#983414, @Ricordisamoa wrote:

Escaping | as {{!}} (like @MarkTraceur did) should do the job, since the latter is a core parser function.

The problem is that some pipes should not be escaped at all. Photos by: Ernesto Di Stefano | George Pimentel Photography should be converted into description={{en|Photos by: Ernesto Di Stefano {{!}} George Pimentel Photography}} (or |, does not matter much) but Photos by: Ernesto Di Stefano {{w|George Pimentel Photography}} should result in description={{en|Photos by: Ernesto Di Stefano {{w|George Pimentel Photography}} }}.

Gilles moved this task from Doing to Next up on the Multimedia board.Jan 29 2015, 7:26 PM
Gilles lowered the priority of this task from Unbreak Now! to Low.Jan 29 2015, 7:43 PM
Gilles moved this task from Next up to Prototyping on the Multimedia board.
MarkTraceur moved this task from Prototyping to Next up on the Multimedia board.Feb 4 2015, 5:52 PM
gerritbot added a comment.Feb 5 2015, 4:41 PM

Change 188823 had a related patch set uploaded (by MarkTraceur):
Sanitize flickr descriptions before pre-filling

https://gerrit.wikimedia.org/r/188823

Patch-For-Review

MarkTraceur moved this task from Next up to Needs code review on the Multimedia board.Feb 5 2015, 4:41 PM
Gilles moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Feb 10 2015, 10:06 AM
gerritbot added a comment.Feb 16 2015, 1:40 PM

Change 188823 merged by jenkins-bot:
Sanitize flickr descriptions before pre-filling

https://gerrit.wikimedia.org/r/188823

MarkTraceur mentioned this in rEUWI96ffa3b4a53d: Sanitize flickr descriptions before pre-filling.Feb 16 2015, 1:43 PM
Gilles moved this task from Reviewed, needs improvements to Ready for testing on the Multimedia board.Feb 16 2015, 1:53 PM
RandomDSdevel awarded a token.Mar 5 2015, 7:13 PM
Diffusion mentioned this in rMEXT7557087f3af1: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:23 AM
Diffusion mentioned this in rMEXT00015798e7aa: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….
Diffusion mentioned this in rMEXT6b212201b867: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Mar 11 2015, 6:26 AM
Gilles added a project: Multimedia-Sprint-2015-03-11.Mar 17 2015, 8:57 AM
Gilles moved this task from Backlog to Ready for testing on the Multimedia-Sprint-2015-03-11 board.
Gilles closed this task as Resolved.Mar 18 2015, 1:24 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL