"|" in Flickr description truncates it
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	MarkTraceur
	Dec 11 2014, 9:24 PM

Description

See:

Details

Project	Branch	Lines +/-	Subject
mediawiki/extensions/UploadWizard	master	+47 -5	Sanitize flickr descriptions before pre-filling
mediawiki/extensions/UploadWizard	wmf/1.25wmf14	+9 -9	Revert "Sanitize \| characters in descriptions"
mediawiki/extensions/UploadWizard	wmf/1.25wmf15	+9 -9	Revert "Sanitize \| characters in descriptions"
mediawiki/extensions/UploadWizard	master	+9 -9	Revert "Sanitize \| characters in descriptions"
mediawiki/extensions/UploadWizard	master	+9 -9	Sanitize \| characters in descriptions

Customize query in gerrit

Related Objects

Mentioned In: rMEXT6b212201b867: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard…
rMEXT00015798e7aa: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard…
rMEXT7557087f3af1: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard…
rEUWI96ffa3b4a53d: Sanitize flickr descriptions before pre-filling
rEUWIb249060e21ef: Revert "Sanitize | characters in descriptions"
rEUWId6a630f77e3a: Revert "Sanitize | characters in descriptions"
rEUWI8fd6040672e9: Revert "Sanitize | characters in descriptions"
rEUWI154642f854c1: Sanitize | characters in descriptions

Event Timeline

MarkTraceur created this task.Dec 11 2014, 9:24 PM

MarkTraceur claimed this task.

MarkTraceur raised the priority of this task from to Medium.

MarkTraceur updated the task description. (Show Details)

MarkTraceur added projects: Multimedia, UploadWizard.

MarkTraceur moved this task to Next up on the Multimedia board.

MarkTraceur changed Security from none to None.

MarkTraceur added a subscriber: MarkTraceur.

Ricordisamoa added a subscriber: Ricordisamoa.Dec 11 2014, 9:45 PM

MarkTraceur moved this task from Next up to Reviewed, needs improvements on the Multimedia board.Dec 22 2014, 5:22 PM

MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.

Change 181425 had a related patch set uploaded (by MarkTraceur):
Sanitize | characters in descriptions

https://gerrit.wikimedia.org/r/181425

Patch-For-Review

• Tgr moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 23 2014, 8:55 PM

MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 24 2014, 4:29 PM

• Tgr moved this task from Needs code review to Reviewed, needs improvements on the Multimedia board.Dec 24 2014, 5:22 PM

MarkTraceur moved this task from Reviewed, needs improvements to Needs code review on the Multimedia board.Dec 24 2014, 7:25 PM

• Tgr moved this task from Needs code review to Ready for testing on the Multimedia board.Dec 31 2014, 7:46 AM

Change 181425 merged by jenkins-bot:
Sanitize | characters in descriptions

https://gerrit.wikimedia.org/r/181425

MarkTraceur mentioned this in rEUWI154642f854c1: Sanitize | characters in descriptions.Dec 31 2014, 7:47 AM

• Gilles closed this task as Resolved.Jan 14 2015, 3:49 PM

• Gilles moved this task from Ready for testing to Doing on the Multimedia board.

• Gilles added a subscriber: • Gilles.

This is causing major problems on Commons since it breaks templates included in the description.

E.g. https://commons.wikimedia.org/w/index.php?title=File:Scouts_of_the_Japanese_Army.jpg&diff=146765421&oldid=146761665

Change 185487 had a related patch set uploaded (by Gergő Tisza):
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185487

Patch-For-Review

Change 185487 merged by jenkins-bot:
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185487

• Tgr mentioned this in rEUWI8fd6040672e9: Revert "Sanitize | characters in descriptions".Jan 16 2015, 7:48 PM

Change 185493 had a related patch set uploaded (by MarkTraceur):
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185493

Patch-For-Review

Change 185494 had a related patch set uploaded (by MarkTraceur):
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185494

Patch-For-Review

Change 185493 merged by MarkTraceur:
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185493

MarkTraceur mentioned this in rEUWId6a630f77e3a: Revert "Sanitize | characters in descriptions".Jan 16 2015, 8:09 PM

Change 185494 merged by jenkins-bot:
Revert "Sanitize | characters in descriptions"

https://gerrit.wikimedia.org/r/185494

MarkTraceur mentioned this in rEUWIb249060e21ef: Revert "Sanitize | characters in descriptions".Jan 16 2015, 8:16 PM

Reverted, backported. People put stuff like {{w|foo}} in descriptions, and that should continue to work. Seems hard to do without doing some lightweight wikitext parsing.

Escaping | as {{!}} (like @MarkTraceur did) should do the job, since the latter is a core parser function.

In T78336#983414, @Ricordisamoa wrote:

Escaping | as {{!}} (like @MarkTraceur did) should do the job, since the latter is a core parser function.

The problem is that some pipes should not be escaped at all. Photos by: Ernesto Di Stefano | George Pimentel Photography should be converted into description={{en|Photos by: Ernesto Di Stefano {{!}} George Pimentel Photography}} (or |, does not matter much) but Photos by: Ernesto Di Stefano {{w|George Pimentel Photography}} should result in description={{en|Photos by: Ernesto Di Stefano {{w|George Pimentel Photography}} }}.