Page MenuHomePhabricator
Create Task
Maniphest T78339

"Validate Again" functionality is broken {dove}
Closed, ResolvedPublic
Actions

Description

Validate Again functionality is disabled in the cohort detail page, because it is broken:
A cohort which has some valid and some invalid users will end up with ALL invalid users if this functionality is used as is.

Details

SubjectRepoBranchLines +/-
WIP: Fix validate again functionality on cohort display pageanalytics/wikimetricsmaster+189 -133
Customize query in gerrit

Related Objects

Event Timeline

mforns created this task.Dec 11 2014, 9:44 PM
mforns raised the priority of this task from to Needs Triage.
mforns updated the task description. (Show Details)
mforns added projects: Analytics-Wikimetrics, Analytics-Engineering.
mforns changed Security from none to None.
mforns subscribed.
• kevinator triaged this task as Medium priority.Dec 15 2014, 11:42 PM
• kevinator mentioned this in T92985: Onboard Madhu.Mar 17 2015, 5:34 PM
Milimetric assigned this task to • madhuvishy.Apr 16 2015, 3:51 PM
Milimetric added a project: Analytics-Kanban.
Milimetric moved this task from Next Up to Paused on the Analytics-Kanban board.Apr 16 2015, 3:53 PM
Milimetric moved this task from Paused to In Progress on the Analytics-Kanban board.
gerritbot subscribed.Apr 24 2015, 1:26 AM

Change 206346 had a related patch set uploaded (by Madhuvishy):
Add column raw_id_or_name to wiki_user

https://gerrit.wikimedia.org/r/206346

gerritbot added a project: Patch-For-Review.Apr 24 2015, 1:26 AM
• kevinator moved this task from In Progress to Paused on the Analytics-Kanban board.Apr 28 2015, 3:49 PM
• kevinator moved this task from Paused to In Progress on the Analytics-Kanban board.May 5 2015, 3:33 PM
• madhuvishy moved this task from In Progress to In Code Review on the Analytics-Kanban board.May 6 2015, 9:32 PM
• madhuvishy added a subscriber: Milimetric.
• ggellerman moved this task from In Code Review to In Progress on the Analytics-Kanban board.May 8 2015, 3:46 PM
• madhuvishy moved this task from In Progress to In Code Review on the Analytics-Kanban board.May 13 2015, 9:32 PM
gerritbot added a comment.May 14 2015, 7:12 PM

Change 206346 merged by Mforns:
WIP: Fix validate again functionality on cohort display page

https://gerrit.wikimedia.org/r/206346

• madhuvishy mentioned this in rANWM069114e3fe58: WIP: Fix validate again functionality on cohort display page.May 15 2015, 7:05 AM
• ggellerman moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.May 15 2015, 3:41 PM
• ggellerman moved this task from Ready to Deploy to Done on the Analytics-Kanban board.
• ggellerman moved this task from Done to Ready to Deploy on the Analytics-Kanban board.
• madhuvishy closed this task as Resolved.May 15 2015, 4:01 PM

This change is done and was deployed.

• kevinator renamed this task from "Validate Again" functionality is broken to "Validate Again" functionality is broken {dove}.May 19 2015, 7:22 PM
• kevinator moved this task from Ready to Deploy to Done on the Analytics-Kanban board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL