Page MenuHomePhabricator
Create Task
Maniphest T78373

Change Special:ChangePassword to use OOUI (to match styling of Special:UserLogin)
Closed, ResolvedPublic
Actions

Description

  1. Reset password
  2. Log in with it, this yields the "Create a new password" screen, courtesy of Special:ResetPassword proxied through SpecialUserLogin
  3. Trigger any error or callback or rate limit. That will respond from ResetPassword (in the url) as that's where the form submits to.

It shows exact same form again, with my values still filled. Except now the form looks completely unstyled.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Change Special:ChangePassword to use OOUImediawiki/coremaster+34 -25
Force MediaWiki UI true on Special:ChangePasswordmediawiki/coremaster+6 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Dec 12 2014, 5:08 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: MediaWiki-User-Interface, MediaWiki-Special-pages, MediaWiki-User-login-and-signup, Regression.
Krinkle changed Security from none to None.
Krinkle added subscribers: Krinkle, Jdlrobson.
Aklapper triaged this task as Low priority.Dec 14 2014, 10:31 PM
• Reguyla moved this task from To triage to Passwords/Email on the MediaWiki-Special-pages board.May 26 2015, 12:23 PM
Florian claimed this task.Sep 15 2015, 5:15 PM
Florian subscribed.

The problem is, that Special:UserLogin forces mediawiki UI to "on", and proxies SpecialChangePassword for the first request (to announce, that you need to change the password). After you submited the form, you will be on Special:ChangeEmail which doesn't have mediwiki ui enabled.

I think the short term fix would be to enable MediaWiki UI on Special:ChangePassword, and the long term to rewrite SpecialChangPassword in OOUI.

gerritbot subscribed.Sep 15 2015, 5:21 PM

Change 238497 had a related patch set uploaded (by Florianschmidtwelzow):
Force MediaWiki UI true on Special:ChangePassword

https://gerrit.wikimedia.org/r/238497

gerritbot added a project: Patch-For-Review.Sep 15 2015, 5:21 PM
gerritbot added a comment.Sep 15 2015, 5:56 PM

Change 238505 had a related patch set uploaded (by Florianschmidtwelzow):
Change Special:ChangePassword to use OOUI

https://gerrit.wikimedia.org/r/238505

gerritbot added a comment.Oct 14 2015, 6:54 AM

Change 238497 abandoned by Florianschmidtwelzow:
Force MediaWiki UI true on Special:ChangePassword

Reason:
please review: Id76883

https://gerrit.wikimedia.org/r/238497

gerritbot added a comment.Nov 3 2015, 6:03 PM

Change 238505 merged by jenkins-bot:
Change Special:ChangePassword to use OOUI

https://gerrit.wikimedia.org/r/238505

Jdlrobson closed this task as Resolved.Nov 3 2015, 6:16 PM
ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Nov 3 2015, 7:00 PM
matmarex renamed this task from Password reset switches from mediawiki-ui to normal style after first submit to Change Special:ChangePassword to use OOUI (to match styling of Special:UserLogin).Nov 4 2015, 6:26 PM
matmarex removed a project: Patch-For-Review.
matmarex added a parent task: T107037: Convert all MW core special pages to OOUI.Nov 4 2015, 6:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits