Page MenuHomePhabricator
Create Task
Maniphest T78389

Fix the way zotero urls are handled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Should clone, not format Zotero urls to make sure the same obj. isn't being modified.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Make zotero.js an objectMvolzmediawiki/services/citoidmaster+90 -112
Customize query in gerrit

Related Objects
Search...

Event Timeline

Mvolz created this task.Dec 12 2014, 12:19 PM
Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added a project: Citoid.
Mvolz changed Security from none to None.
Mvolz subscribed.
Mvolz added a subtask: T89968: Make requests.js an object and pass through citoid config.Feb 19 2015, 4:55 PM
Mvolz moved this task from Backlog to Service on the Citoid board.Feb 21 2015, 1:20 PM
gerritbot subscribed.Feb 22 2015, 3:42 PM

Change 192197 had a related patch set uploaded (by Mvolz):
[WIP] Make zotero.js an object

https://gerrit.wikimedia.org/r/192197

Patch-For-Review

Aklapper added a project: Patch-For-Review.Feb 23 2015, 5:17 PM
gerritbot added a comment.Feb 24 2015, 4:23 PM

Change 192197 abandoned by Mvolz:
Make zotero.js an object

Reason:
Whoops.

https://gerrit.wikimedia.org/r/192197

gerritbot added a comment.Feb 24 2015, 4:25 PM

Change 192197 restored by Mvolz:
Make zotero.js an object

https://gerrit.wikimedia.org/r/192197

Mvolz closed subtask T89968: Make requests.js an object and pass through citoid config as Resolved.Feb 26 2015, 7:56 PM
gerritbot added a comment.Mar 2 2015, 6:41 PM

Change 192197 merged by Mobrovac:
Make zotero.js an object

https://gerrit.wikimedia.org/r/192197

Jdforrester-WMF closed this task as Resolved.Mar 2 2015, 6:43 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Mar 29 2015, 11:41 PM
Jdforrester-WMF assigned this task to Mvolz.Mar 29 2015, 11:45 PM
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Mar 29 2015, 11:48 PM
Mvolz mentioned this in rGCITdf82fe3a3b58: Make zotero.js an object.Apr 8 2015, 4:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits