Page MenuHomePhabricator

PopupToolGroup technical debt is demanding that we pay it
Closed, ResolvedPublic

Description

PopupToolGroup technical debt is demanding that we pay it.

.oo-ui-popupToolGroup {
	…
		.oo-ui-tool-title {
			…
			// HACK: We take 100% of available width, but there's already an icon taking space before this element.
			// Offset by 2.25em to match icon width+margin, 0.25em more to avoid border overlap
			margin-right: -2.5em;
			…
			.oo-ui-tool-accel {
				…
				// HACK: 2.25em to match icon width+margin, 0.25em more to avoid border overlap
				padding-right: 2.5em;
			}
	…
}

Event Timeline

Change 179786 had a related patch set uploaded (by Bartosz Dziewoński):
[BREAKING CHANGE] PopupToolGroup and friends: Pay off technical debt

https://gerrit.wikimedia.org/r/179786

Patch-For-Review

Change 179788 had a related patch set uploaded (by Bartosz Dziewoński):
Update for Idc299e23 in OOUI

https://gerrit.wikimedia.org/r/179788

Patch-For-Review

Change 179789 had a related patch set uploaded (by Bartosz Dziewoński):
Update for Idc299e23 in OOUI

https://gerrit.wikimedia.org/r/179789

Patch-For-Review

matmarex moved this task from Backlog to Next-up on the OOUI board.Dec 14 2014, 7:18 PM

Change 179786 merged by jenkins-bot:
[BREAKING CHANGE] PopupToolGroup and friends: Pay off technical debt

https://gerrit.wikimedia.org/r/179786

Jdforrester-WMF triaged this task as High priority.Dec 15 2014, 7:30 PM
Jdforrester-WMF moved this task from Next-up to Reviewing on the OOUI board.Mar 26 2015, 8:55 PM