For upgraders

To 1.24?

Yes, for upgraders to 1.24.

As far as I see, the indeces can without problem be made unique: For each of these three indeces, there already are other indeces, which use exactly the same columns (in a different order, but the same columns). And these other indeces already are unique:

• il_to => same columns as the unique index il_from
• pl_namespace => same columns as the unique index pl_from
• tl_namespace => same columns as the unique index tl_from

These indeces already are unique, so basically what we have in il_to, pl_namespace and tl_namespace will be unique anyway.

(Or with other words: Even if the three new indeces were not unique indeces, then what they contain would be unique anyway, as the other, already existing indeces take care that only unique stuff will be there. So making them unique, as done in the patch file, is correct. This is why I proposed not to fix this in the patch file, but in tables.sql.)

Was removed with https://gerrit.wikimedia.org/r/#/c/117373/

Thanks for digging out the history of this bug! This is more a cosmetical issue - I don't care, which of the two solutions you take. Just pick one. But if you ask me, I would make the index unique again. The content is unique so let's also call it unique. As pointed out this can be done without causing technical issues for the user. The overhead of the (unique) constraint compared to the non unique index is insignificant.

Change 306895 had a related patch set uploaded (by PleaseStand):
Remove patch-pl-tl-il-unique.sql

https://gerrit.wikimedia.org/r/306895

Change 306895 merged by jenkins-bot:
Remove patch-pl-tl-il-unique.sql

https://gerrit.wikimedia.org/r/306895