Page MenuHomePhabricator
Create Task
Maniphest T78546

Edit source tab should not hijack middle-click
Closed, ResolvedPublic
Actions

Description

Click on the edit source tab with the mouse wheel or middle mouse button.

Expected behavior: edit source opens in new tab

Actual behavior: dialog opens asking if I want to retain my changes

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Edit/view source tab: Do not hijack middle click to display confirmation, only left clickmediawiki/extensions/VisualEditormaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Catrope created this task.Dec 15 2014, 1:53 PM
Catrope assigned this task to Krenair.
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added a project: VisualEditor.
Catrope changed Security from none to None.
Catrope subscribed.
Jdforrester-WMF triaged this task as Medium priority.Dec 15 2014, 5:16 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
gerritbot added a project: Patch-For-Review.Dec 15 2014, 7:31 PM

Change 179975 had a related patch set uploaded (by Alex Monk):
Edit/view source tab: Do not hijack middle click to display confirmation, only left click

https://gerrit.wikimedia.org/r/179975

Patch-For-Review

gerritbot added a comment.Dec 16 2014, 7:57 AM

Change 179975 merged by jenkins-bot:
Edit/view source tab: Do not hijack middle click to display confirmation, only left click

https://gerrit.wikimedia.org/r/179975

Krenair mentioned this in rEVEDf9339d070b03: Edit/view source tab: Do not hijack middle click to display confirmation, only….Dec 16 2014, 7:58 AM
Jdforrester-WMF closed this task as Resolved.Dec 16 2014, 5:42 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to FY 18-19 Q3/Q4 on the VisualEditor board.
Jdforrester-WMF added a project: WMF-deploy-2014-12-17_(1.25wmf13).
Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM
Ricordisamoa subscribed.Jan 11 2015, 12:12 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Aug 5 2015, 1:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits