Page MenuHomePhabricator

Edit source tab should not hijack middle-click
Closed, ResolvedPublic

Description

Click on the edit source tab with the mouse wheel or middle mouse button.

Expected behavior: edit source opens in new tab

Actual behavior: dialog opens asking if I want to retain my changes

Details

Related Gerrit Patches:

Event Timeline

Catrope created this task.Dec 15 2014, 1:53 PM
Catrope assigned this task to Krenair.
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added a project: VisualEditor.
Catrope changed Security from none to None.
Catrope added a subscriber: Catrope.
Jdforrester-WMF triaged this task as Medium priority.Dec 15 2014, 5:16 PM
Jdforrester-WMF moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

Change 179975 had a related patch set uploaded (by Alex Monk):
Edit/view source tab: Do not hijack middle click to display confirmation, only left click

https://gerrit.wikimedia.org/r/179975

Patch-For-Review

Change 179975 merged by jenkins-bot:
Edit/view source tab: Do not hijack middle click to display confirmation, only left click

https://gerrit.wikimedia.org/r/179975

Jdforrester-WMF closed this task as Resolved.Dec 16 2014, 5:42 PM
Jdforrester-WMF moved this task from TR6: Visual diffs to Q4 on the VisualEditor board.