Page MenuHomePhabricator
Create Task
Maniphest T78556

hhvm on CI slaves can not find PEAR.php
Closed, ResolvedPublic
Actions

Description

When running CirrusSearch unit tests under HHVM, the build fails with:

Fatal error: File not found: PEAR.php in mwext-CirrusSearch-testextension-hhvm/src/extensions/TimedMediaHandler/handlers/OggHandler/PEAR/File_Ogg/File/Ogg.php on line 123

Jenkins job: https://integration.wikimedia.org/ci/job/mwext-CirrusSearch-testextension-hhvm/

We do have the Debian package php-pear installed which install the files under /usr/share/php/. HHVM does not have that directory in its include path whereas the Zend version does:

$ fgrep -R /usr/share /etc/php5
/etc/php5/cli/php.ini:;include_path = ".:/usr/share/php"
/etc/php5/apache2/php.ini:;include_path = ".:/usr/share/php"

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
hhvm: fix include_pathoperations/puppetproduction+5 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Dec 15 2014, 5:22 PM
hashar raised the priority of this task from to High.
hashar updated the task description. (Show Details)
hashar added projects: HHVM, Continuous-Integration-Infrastructure, TimedMediaHandler, CirrusSearch.
hashar changed Security from none to None.
hashar updated the task description. (Show Details)
hashar added subscribers: scfc, greg, ori and 5 others.
hashar added a comment.Dec 15 2014, 6:58 PM

Seems to be an issue in TimedMediaHandler which fails under hhvm https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-testextension-hhvm/1/console

hashar added a comment.Dec 15 2014, 7:24 PM

/etc/hhvm/php.ini needs to be amended:

- hhvm.include_path = .:/usr/share/php
+ include_path = ".:/usr/share/php"

The double quotes around matter :-(

hashar claimed this task.Dec 15 2014, 7:29 PM
gerritbot added a project: Patch-For-Review.Dec 15 2014, 7:30 PM

Change 179974 had a related patch set uploaded (by Hashar):
hhvm: fix include_path

https://gerrit.wikimedia.org/r/179974

Patch-For-Review

hashar moved this task from Untriaged to In-progress on the Continuous-Integration-Infrastructure board.Dec 15 2014, 7:31 PM
hashar edited projects, added acl*sre-team; removed CirrusSearch.Dec 15 2014, 7:38 PM

Cherry picked on contint puppetmaster and it fixed the build of TimedMediaHandler under HHVM https://integration.wikimedia.org/ci/job/mwext-TimedMediaHandler-testextension-hhvm/

This task is now pending ops review / merge.

hashar moved this task from In-progress to Externally Blocked on the Continuous-Integration-Infrastructure board.Dec 15 2014, 8:40 PM
Krinkle added a comment.Dec 16 2014, 2:27 AM

The usage for both CirrusSearch and TimedMediaHandler stems from OggHandler:

OggHandler/PEAR/File_Ogg/File/Ogg.php:

require_once('PEAR.php');
require_once('PEAR/Exception.php');
gerritbot added a comment.Dec 16 2014, 2:32 AM

Change 179974 merged by Ori.livneh:
hhvm: fix include_path

https://gerrit.wikimedia.org/r/179974

ori mentioned this in Unknown Object (Diffusion Commit).Dec 16 2014, 2:32 AM
• Gilles added a project: Multimedia.Dec 16 2014, 10:36 AM
hashar closed this task as Resolved.Dec 16 2014, 1:22 PM

TimedMediaHandler is happy, thank you! https://integration.wikimedia.org/ci/job/mwext-CirrusSearch-testextension-hhvm/2/console

ori mentioned this in rOPUP8d5947395646: hhvm: fix include_path.Dec 30 2014, 7:59 PM
hashar moved this task from Externally Blocked to Done on the Continuous-Integration-Infrastructure board.Jan 5 2015, 9:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits