Page MenuHomePhabricator

Clicking topic titlebar or post Reply link warns "Validation error against schema FlowReplies: Unrecognized property: schema"
Closed, ResolvedPublic

Description

Also same warning clicking [Cancel] or [Reply] buttons below the post entry form.

One time this manifested as a JS error and the entry box didn't expand, although it did show the form buttons. I can't reproduce that.

Event Timeline

Spage raised the priority of this task from to Needs Triage.
Spage updated the task description. (Show Details)
Spage changed Security from none to None.
Spage added a subscriber: Spage.
Spage added a comment.EditedDec 15 2014, 8:01 PM

modules/engine/components/common/flow-component-events.js gets the schema from the data.flowEventlogSchema data attribute, but leaves this in the logEvent payload (second parameter) as schema. It should filter it out.

Spage renamed this task from Clicking topic titlebar Reply warns "Validation error against schema FlowReplies: Unrecognized property: schema" to Clicking topic titlebar or post Reply link warns "Validation error against schema FlowReplies: Unrecognized property: schema".Dec 15 2014, 8:01 PM

Change 179983 had a related patch set uploaded (by EBernhardson):
Dont pass along schema as an eventlogging argument

https://gerrit.wikimedia.org/r/179983

Patch-For-Review

Change 179983 merged by jenkins-bot:
Don't pass along schema as an EventLogging argument

https://gerrit.wikimedia.org/r/179983

Change 180043 had a related patch set uploaded (by EBernhardson):
Don't pass along schema as an EventLogging argument

https://gerrit.wikimedia.org/r/180043

Patch-For-Review

Change 180043 merged by jenkins-bot:
Don't pass along schema as an EventLogging argument

https://gerrit.wikimedia.org/r/180043