Clicking topic titlebar or post Reply link warns "Validation error against schema FlowReplies: Unrecognized property: schema"
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• Spage
	Dec 15 2014, 7:38 PM

Description

Also same warning clicking [Cancel] or [Reply] buttons below the post entry form.

One time this manifested as a JS error and the entry box didn't expand, although it did show the form buttons. I can't reproduce that.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Don't pass along schema as an EventLogging argument	mediawiki/extensions/Flow	wmf/1.25wmf12	+8 -4
	Don't pass along schema as an EventLogging argument	mediawiki/extensions/Flow	master	+8 -4

Customize query in gerrit

Revisions and Commits

rEFLW extension-Flow
	rEFLW00df5a57f623 Dont pass along schema as an eventlogging argument
	rEFLW779b60cdce1c Dont pass along schema as an eventlogging argument
	rEFLW0da20422c84a Don't pass along schema as an EventLogging argument
	rEFLW3e3059ec1de3 Don't pass along schema as an EventLogging argument
rMEXT MediaWiki Extensions
	rMEXT1575fff372e7 Updated mediawiki/extensions Project: mediawiki/extensions/Flow…

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Duplicate		None	T78578 Retest all FlowReplies logging paths and make sure they validate
		Resolved		None	T78577 Clicking topic titlebar or post Reply link warns "Validation error against schema FlowReplies: Unrecognized property: schema"

Event Timeline

• Spage created this task.Dec 15 2014, 7:38 PM

• Spage raised the priority of this task from to Needs Triage.

• Spage updated the task description. (Show Details)

• Spage added projects: StructuredDiscussions, Collaboration-Team-Triage.

• Spage changed Security from none to None.

• Spage subscribed.

modules/engine/components/common/flow-component-events.js gets the schema from the data.flowEventlogSchema data attribute, but leaves this in the logEvent payload (second parameter) as schema. It should filter it out.

• Spage renamed this task from Clicking topic titlebar Reply warns "Validation error against schema FlowReplies: Unrecognized property: schema" to Clicking topic titlebar or post Reply link warns "Validation error against schema FlowReplies: Unrecognized property: schema".Dec 15 2014, 8:01 PM

Change 179983 had a related patch set uploaded (by EBernhardson):
Dont pass along schema as an eventlogging argument

https://gerrit.wikimedia.org/r/179983

Patch-For-Review

Change 179983 merged by jenkins-bot:
Don't pass along schema as an EventLogging argument

https://gerrit.wikimedia.org/r/179983

Closed by commit rEFLW3e3059ec1de3.

Change 180043 had a related patch set uploaded (by EBernhardson):
Don't pass along schema as an EventLogging argument

https://gerrit.wikimedia.org/r/180043

Patch-For-Review

Change 180043 merged by jenkins-bot:
Don't pass along schema as an EventLogging argument

https://gerrit.wikimedia.org/r/180043

EBernhardson added a commit: rEFLW0da20422c84a: Don't pass along schema as an EventLogging argument.Dec 16 2014, 12:21 AM

Diffusion added a commit: rMEXT1575fff372e7: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 4:38 AM

• DannyH moved this task from Untriaged to Resolved on the Collaboration-Team-Triage board.Apr 7 2015, 5:50 PM

EBernhardson added a commit: rEFLW779b60cdce1c: Dont pass along schema as an eventlogging argument.Apr 28 2016, 2:41 AM

EBernhardson added a commit: rEFLW00df5a57f623: Dont pass along schema as an eventlogging argument.

Clicking topic titlebar or post Reply link warns "Validation error against schema FlowReplies: Unrecognized property: schema"Closed, ResolvedPublicActions