Page MenuHomePhabricator

Remove display:block from CtaDrawer
Closed, ResolvedPublic

Description

The sign up link in MobileFrontend (in CtaDrawer [1]) have display:block which results in a not visible clickable area at the left and right side of the link. This should be removed.

[1] Steps to reproduce: Go to a wikimedia wiki, logout and open an article. Click the edit pencil and you see the CtaDrawer with login and signup link.

Event Timeline

Florian claimed this task.
Florian raised the priority of this task from to Medium.
Florian updated the task description. (Show Details)
Florian changed Security from none to None.
Florian added a subscriber: Florian.

Change 173283 had a related patch set uploaded (by Florianschmidtwelzow):
Hygiene: Remove anchor links from ctaDrawer

https://gerrit.wikimedia.org/r/173283

Patch-For-Review

Florian, since the issue is with the entire area being clickable just wrap the link in div's and let's remove the display: block;
Keep the buttons positioned center and on single lines, let's not introduce any design changes here.

Change 173283 merged by jenkins-bot:
Hygiene: Remove mw-ui-block modifier from anchor links in ctaDrawer

https://gerrit.wikimedia.org/r/173283