Page MenuHomePhabricator
Create Task
Maniphest T78592

EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions
Closed, ResolvedPublic
Actions

Description

When running Echo extensions tests under HHVM/Zend, Jenkins ends up with a failure:

1) EchoTitleLocalCacheTest::testGet
Failed asserting that null is an instance of class "Title".

extensions/Echo/tests/phpunit/includes/cache/TitleLocalCacheTest.php:37
tests/phpunit/MediaWikiTestCase.php:141

In a workspace with the following extensions:

mediawiki/extensions/Echo
mediawiki/extensions/JsonConfig
mediawiki/extensions/Mantle
mediawiki/extensions/MobileApp
mediawiki/extensions/MobileFrontend
mediawiki/extensions/VisualEditor
mediawiki/extensions/WikiGrok
mediawiki/extensions/ZeroBanner
mediawiki/extensions/ZeroPortal

Running the Echo tests standalone pass ( php tests/phpunit/phpunit.php extensions/Echo )

The whole testsuite fails though:

cd tests/phpunit
php phpunit.php --testsuite extensions

Or slightly faster:

cd tests/phpunit
php phpunit.php --testsuite extensions --filter 'Echo' --stop-on-failure

Details

SubjectRepoBranchLines +/-
Fix EchoTitleLocalCacheTest::testGet corner casemediawiki/extensions/EchoREL1_24+9 -1
Fix EchoTitleLocalCacheTest::testGet corner casemediawiki/extensions/Echomaster+9 -1
Fix EchoTitleLocalCacheTest::testGet corner casemediawiki/extensions/Echowmf/1.25wmf14+9 -1
Fix EchoTitleLocalCacheTest::testGet corner casemediawiki/extensions/Echowmf/1.25wmf13+9 -1
Customize query in gerrit

Revisions and Commits

rECHO extension-Echo
rECHObf5ff9b8ea8a Rework broken echo test to make less assumptions

Related Objects
Search...

Event Timeline

hashar created this task.Dec 15 2014, 8:43 PM
hashar raised the priority of this task from to Needs Triage.
hashar updated the task description. (Show Details)
hashar added projects: Notifications, HHVM.
hashar changed Security from none to None.
hashar added a subscriber: hashar.
hashar updated the task description. (Show Details)Dec 15 2014, 8:46 PM
• Mattflaschen-WMF triaged this task as Unbreak Now! priority.Dec 15 2014, 11:49 PM
• Mattflaschen-WMF added a subscriber: • Mattflaschen-WMF.
hashar added a comment.Dec 16 2014, 1:48 PM

You can trigger the hhvm job on an Echo proposed patch by commenting in Gerrit: "check experimental". That will run a build of https://integration.wikimedia.org/ci/job/mwext-Echo-testextension-hhvm/

• Mattflaschen-WMF assigned this task to • Spage.Dec 24 2014, 7:09 PM
Quiddity added a project: Collaboration-Team-Triage.Jan 5 2015, 6:54 PM
• Mattflaschen-WMF moved this task from Untriaged to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.Jan 5 2015, 6:56 PM
• Spage removed • Spage as the assignee of this task.Jan 5 2015, 9:57 PM
• Spage added a subscriber: • Spage.

I couldn't get MediaWiki-Vagrant to work to reproduce this.

hashar closed this task as Resolved.Jan 6 2015, 1:40 PM
hashar claimed this task.

The standalone job pass now https://integration.wikimedia.org/ci/job/mwext-Echo-testextension-hhvm/3/ but fails when being run with other extensions https://integration.wikimedia.org/ci/job/mediawiki-phpunit-integration-hhvm/11/console

That last job uses:

mediawiki/extensions/Echo
mediawiki/extensions/JsonConfig
mediawiki/extensions/Mantle
mediawiki/extensions/MobileApp
mediawiki/extensions/MobileFrontend
mediawiki/extensions/VisualEditor
mediawiki/extensions/WikiGrok
mediawiki/extensions/ZeroBanner
mediawiki/extensions/ZeroPortal

I can reproduce the failure on my local install using Zend

hashar renamed this task from EchoTitleLocalCacheTest::testGet fails under HHVM to EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions.Jan 6 2015, 1:53 PM
hashar updated the task description. (Show Details)
hashar added a comment.Jan 6 2015, 3:14 PM

Example to reproduce:

cd tests/phpunit
php phpunit.php --testsuite extensions --filter 'Echo' --stop-on-failure

There must be a race condition somewhere in the MRU Cache or Title local cache.

hashar reopened this task as Open.Jan 8 2015, 10:10 AM

I forgot to reopen this task, see above for a way to reproduce.

hashar added a subscriber: Collaboration-Team-Triage.Jan 8 2015, 3:04 PM

Could someone from the Collaboration-Team-Triage assist in tracking down this bug? I have looked a bit at the cache code and attempted to debug it but eventually got lost in the code :-/

The way to reproduce:

Clone core / vendor and:

mediawiki/extensions/Echo
mediawiki/extensions/JsonConfig
mediawiki/extensions/Mantle
mediawiki/extensions/MobileApp
mediawiki/extensions/MobileFrontend
mediawiki/extensions/VisualEditor
mediawiki/extensions/WikiGrok
mediawiki/extensions/ZeroBanner
mediawiki/extensions/ZeroPortal

Setup a basic wiki via maintenance/install.php

cd tests/phpunit
php phpunit.php --testsuite extensions --filter 'Echo' --stop-on-failure

Should fails.

If one only run the Echo tests they pass ( php tests/phpunit.php extensions/Echo ).

• DannyH renamed this task from EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions to EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions (Unbreak Now).Jan 8 2015, 6:50 PM
• Mattflaschen-WMF removed hashar as the assignee of this task.Jan 8 2015, 7:25 PM
gerritbot added a project: Patch-For-Review.Jan 9 2015, 12:57 PM

Change 183840 had a related patch set uploaded (by Hashar):
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/183840

Patch-For-Review

hashar added a comment.Jan 9 2015, 1:36 PM

The patch 183840 for Echo does fix the job testing multiple extensions together:

https://integration.wikimedia.org/ci/job/mediawiki-phpunit-integration-hhvm/15/console

Pending review/merge.

gerritbot added a comment.Jan 9 2015, 3:30 PM

Change 183840 merged by jenkins-bot:
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/183840

hashar mentioned this in rECHO7f5b0c17933e: Fix EchoTitleLocalCacheTest::testGet corner case.Jan 9 2015, 3:31 PM
hashar closed this task as Resolved.Jan 9 2015, 3:32 PM
hashar claimed this task.

Merged in by Matthias \O/

gerritbot added a comment.Jan 12 2015, 2:24 PM

Change 184343 had a related patch set uploaded (by Hashar):
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/184343

Patch-For-Review

gerritbot added a comment.Jan 12 2015, 2:24 PM

Change 184344 had a related patch set uploaded (by Hashar):
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/184344

Patch-For-Review

gerritbot added a comment.Jan 12 2015, 2:28 PM

Change 184343 merged by jenkins-bot:
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/184343

gerritbot added a comment.Jan 12 2015, 2:28 PM

Change 184344 merged by jenkins-bot:
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/184344

hashar mentioned this in rECHO433db7c1108c: Fix EchoTitleLocalCacheTest::testGet corner case.Jan 12 2015, 2:29 PM
hashar mentioned this in rECHOaf6d2cb62fe5: Fix EchoTitleLocalCacheTest::testGet corner case.
hashar added a comment.Jan 12 2015, 3:11 PM

I have pushed the fix to 1.25wmf13 and 1.25wmf14 mediawiki/core branches (and "deployed").

gerritbot added a comment.Jan 12 2015, 8:23 PM

Change 184420 had a related patch set uploaded (by Hashar):
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/184420

Patch-For-Review

gerritbot added a subscriber: gerritbot.Jan 17 2015, 10:01 PM

Change 184420 abandoned by Hashar:
Fix EchoTitleLocalCacheTest::testGet corner case

https://gerrit.wikimedia.org/r/184420

Krinkle added a subscriber: Krinkle.Jan 29 2015, 11:48 PM

Failed again just now:

https://integration.wikimedia.org/ci/job/mwext-Flow-testextension-zend/344/consoleFull

Krinkle reopened this task as Open.Jan 29 2015, 11:48 PM
Krinkle mentioned this in T88039: Echo unit tests failing when installed with Flow.Jan 30 2015, 12:49 AM
• Mattflaschen-WMF renamed this task from EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions (Unbreak Now) to EchoTitleLocalCacheTest::testGet fails when tests are run with other extensions.Jan 30 2015, 12:51 AM
• Mattflaschen-WMF merged a task: T88022: Echo PHPUnit passes standalone but fails when run with Flow.
• Mattflaschen-WMF added a subscriber: EBernhardson.
Krinkle closed this task as Resolved.EditedJan 30 2015, 12:51 AM

Filed separately as T88039 since that one is not related to HHVM.

• Mattflaschen-WMF merged a task: T88039: Echo unit tests failing when installed with Flow.Jan 30 2015, 12:52 AM
Krinkle reopened this task as Open.Jan 30 2015, 12:52 AM
• Mattflaschen-WMF reassigned this task from hashar to EBernhardson.Jan 30 2015, 12:53 AM
• Mattflaschen-WMF edited projects, added Collaboration-Team-Sprint-P-2015-02-11/q3; removed Collaboration-Team-Triage.
• Mattflaschen-WMF added a commit: rECHObf5ff9b8ea8a: Rework broken echo test to make less assumptions.Jan 30 2015, 12:56 AM
• Mattflaschen-WMF closed this task as Resolved.Jan 30 2015, 12:59 AM
• DannyH moved this task from Sprint P - ends Feb 11 to Product Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 30 2015, 6:33 PM
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 4 2015, 12:00 AM
RandomDSdevel awarded a token.Mar 2 2015, 9:54 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
hashar mentioned this in rMEXT348c9e2b204e: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Mar 11 2015, 6:23 AM
• Phabricator_maintenance added a project: Collaboration-Team-Triage.Aug 12 2016, 11:54 AM
• Phabricator_maintenance removed a subscriber: Collaboration-Team-Triage.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 12 2016, 11:54 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL