Page MenuHomePhabricator
Create Task
Maniphest T78644

Give transparent embedded image files in Phabricator a checkered background
Closed, ResolvedPublic
Actions

Description

MediaWiki (discussed in T28470) gives transparent files a checkered background so that one can actually see it; we should consider doing this in Phabricator too, as currently you cannot see white images easily (such as the white Wikimedia logo attached to T69).

Upstream: https://we.phorge.it/T15473

Related Objects
Search...

Event Timeline

MC8 created this task.Dec 16 2014, 11:20 AM
MC8 raised the priority of this task from to Low.
MC8 updated the task description. (Show Details)
MC8 added a project: Phabricator.
MC8 changed Security from none to None.
MC8 subscribed.
Qgil edited projects, added Phabricator (Upstream); removed Phabricator.Dec 16 2014, 11:42 AM
Qgil moved this task from Backlog to Ready To Go on the Phabricator (Upstream) board.Dec 17 2014, 9:53 AM
Qgil subscribed.Jan 16 2015, 10:27 AM

@MC8, would it be too much to ask for a link to the code providing this checkered background in MediaWiki? I'm happy to file this request upstream, and a link to our solutions will be useful.

MC8 added a comment.EditedJan 16 2015, 10:41 AM

The MediaWiki equivalent of this task is T28470, which resulted in this code being added to skins/common/shared.css:

.filehistory a img,
#file img:hover {
    /* @embed */
    background: white url(images/Checker-16x16.png) repeat;
}

Here's an example blank image.

Qgil lowered the priority of this task from Low to Lowest.Mar 13 2015, 11:59 AM
Nemo_bis awarded a token.Apr 7 2015, 8:39 AM
Danny_B added a project: Upstream.May 23 2016, 6:03 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptMay 23 2016, 6:03 PM
Aklapper renamed this task from We should give transparent attachments in Phabricator a checkered background to Give transparent embedded image files in Phabricator a checkered background.Jun 14 2023, 6:40 PM
Aklapper raised the priority of this task from Lowest to Low.
Aklapper updated the task description. (Show Details)
Aklapper moved this task from Backlog to Reported Upstream on the Upstream board.
Aklapper moved this task from Ready To Go to Upstreamed on the Phabricator (Upstream) board.
Aklapper claimed this task.Jun 14 2023, 6:44 PM
Aklapper moved this task from Reported Upstream to Patch proposed upstream on the Upstream board.
valerio.bozzolan awarded a token.Jun 14 2023, 7:01 PM
valerio.bozzolan subscribed.
Aklapper changed the task status from Open to Stalled.Jun 19 2023, 9:57 AM
Aklapper moved this task from Patch proposed upstream to Patch merged upstream on the Upstream board.
Aklapper moved this task from Upstreamed to Solved upstream on the Phabricator (Upstream) board.
Aklapper edited projects, added Phabricator (2023-08-23); removed Phabricator (Upstream).Jul 12 2023, 8:07 PM
Aklapper moved this task from 2023-08-23 to 2023-10-03 on the Phabricator board.Aug 23 2023, 3:34 PM
Aklapper edited projects, added Phabricator (2023-10-03); removed Phabricator (2023-08-23).
Aklapper moved this task from 2023-10-03 to 2023-10-17 on the Phabricator board.Oct 3 2023, 3:22 PM
Aklapper edited projects, added Phabricator (2023-10-17); removed Phabricator (2023-10-03).
brennen moved this task from 2023-10-17 to 2023-11-14 on the Phabricator board.Oct 16 2023, 10:06 PM
brennen edited projects, added Phabricator (2023-11-14); removed Phabricator (2023-10-17).
Aklapper edited projects, added Phabricator (Upstream); removed Phabricator (2023-11-14).Nov 9 2023, 4:50 PM

[Move tasks resolved in upstream from #phabricator-next (as not every deployment will also pull an updated upstream) to the "Solved upstream" column on the Phabricator (Upstream) workboard]

valerio.bozzolan added a comment.Nov 10 2023, 1:59 AM

Ah, since somebody asked (?) yes, this feature is in this upstream changelog:

https://we.phorge.it/w/changelog/2023.32/

Aklapper added a subtask: T358610: Update wmf/stable to Phorge upstream's 2023.49 stable release.Mar 17 2024, 4:39 PM
Aklapper closed this task as Resolved.Mar 21 2024, 3:30 PM

This issue should be resolved in phabricator.wikimedia.org since 2024-03-19 thanks to brennen's deployment in T358610. Please reopen if you still experience this issue.

Aklapper closed subtask T358610: Update wmf/stable to Phorge upstream's 2023.49 stable release as Resolved.Mar 21 2024, 8:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL