Page MenuHomePhabricator

[Task] Test actual search logic
Closed, InvalidPublic

Description

"Perhaps I'm missing something, but at least for the QuantityHandler, I could not see where the actual search behavior is tested. E.g. if I search for 12+/-2, the value 11+/-1 should be fouund, but the value 10+/-5 should not. This needs to be tested somewhere."

https://github.com/wmde/WikibaseQueryEngine/issues/72

Event Timeline

Lucie raised the priority of this task from to Needs Triage.
Lucie updated the task description. (Show Details)
Lucie changed Security from none to None.
Lucie added subscribers: Aklapper, Lucie.
Lydia_Pintscher raised the priority of this task from Medium to High.Jun 30 2015, 8:59 AM
Lydia_Pintscher moved this task from consider for next sprint to hold on the Wikidata board.

@Lydia_Pintscher @thiemowmde why the raised priority and new activity here? I was under the impression we where not continuing with our own queries. Do we have a new plan?

We might come back to this for what we currently call "stupid queries". But we obviously can not use a component with zero integration tests. The integration tests are there but not reviewed and not merged for 13 months now:

Lydia_Pintscher claimed this task.

We decided to not work on this given that the SPARQL endpoint seems to be working well and covering most usecases.