Page MenuHomePhabricator
Create Task
Maniphest T78694

"Watch this page" option does not reflect the status of the article if it was changed without reloading
Closed, ResolvedPublic
Actions

Description

See this screencast by Benutzer:André Schneider , where he adds an article on the German Wikipedia to his watchlist, then tries to VEdit said article; the corresponding checkbox in the Save dialog is not ticked, so when he saves the article is not in his watchlist anymore.

Details

SubjectRepoBranchLines +/-
Update "Watch this page" option when necessarymediawiki/extensions/VisualEditormaster+15 -3
Customize query in gerrit

Related Objects

Event Timeline

• Elitre created this task.Dec 16 2014, 6:45 PM
• Elitre raised the priority of this task from to Needs Triage.
• Elitre updated the task description. (Show Details)
• Elitre added a project: VisualEditor.
• Elitre changed Security from none to None.
• Elitre subscribed.
Krenair added a project: VisualEditor-MediaWiki.Dec 25 2014, 12:28 PM
Krenair subscribed.
Krenair renamed this task from "Watch this page" option does not reflect the status of the article on de.wp to "Watch this page" option does not reflect the status of the article if it was changed without reloading.Dec 30 2014, 2:24 AM
Krenair added a comment.Dec 30 2014, 2:28 AM

So VE sets isPageWatched when the page is initially loaded, but that's not updated if you click a button on the page to watch it. Even if we did update that, it's only checked when the page is initially loaded (so we'd need to check it when the save dialog comes up instead).

Krenair claimed this task.Dec 30 2014, 2:29 AM
gerritbot added a project: Patch-For-Review.Dec 31 2014, 1:46 AM

Change 182336 had a related patch set uploaded (by Alex Monk):
Update "Watch this page" option when necessary

https://gerrit.wikimedia.org/r/182336

Patch-For-Review

Jdforrester-WMF triaged this task as Medium priority.Jan 5 2015, 12:11 PM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 31 2015, 2:45 AM
gerritbot subscribed.Jan 31 2015, 2:46 AM

Change 182336 merged by jenkins-bot:
Update "Watch this page" option when necessary

https://gerrit.wikimedia.org/r/182336

Jdforrester-WMF mentioned this in rEVED9841d1012c17: Update "Watch this page" option when necessary.Jan 31 2015, 2:47 AM
Jdforrester-WMF closed this task as Resolved.Jan 31 2015, 3:48 AM
Jdforrester-WMF edited projects, added WMF-deploy-2015-02-04_(1.25wmf16); removed Patch-For-Review.
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Aug 5 2015, 1:08 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL