Page MenuHomePhabricator

"Watch this page" option does not reflect the status of the article if it was changed without reloading
Closed, ResolvedPublic

Description

See this screencast by Benutzer:André Schneider , where he adds an article on the German Wikipedia to his watchlist, then tries to VEdit said article; the corresponding checkbox in the Save dialog is not ticked, so when he saves the article is not in his watchlist anymore.

Event Timeline

Elitre created this task.Dec 16 2014, 6:45 PM
Elitre raised the priority of this task from to Needs Triage.
Elitre updated the task description. (Show Details)
Elitre added a project: VisualEditor.
Elitre changed Security from none to None.
Elitre added a subscriber: Elitre.
Krenair renamed this task from "Watch this page" option does not reflect the status of the article on de.wp to "Watch this page" option does not reflect the status of the article if it was changed without reloading.Dec 30 2014, 2:24 AM

So VE sets isPageWatched when the page is initially loaded, but that's not updated if you click a button on the page to watch it. Even if we did update that, it's only checked when the page is initially loaded (so we'd need to check it when the save dialog comes up instead).

Krenair claimed this task.Dec 30 2014, 2:29 AM

Change 182336 had a related patch set uploaded (by Alex Monk):
Update "Watch this page" option when necessary

https://gerrit.wikimedia.org/r/182336

Patch-For-Review

Jdforrester-WMF triaged this task as Medium priority.Jan 5 2015, 12:11 PM
Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.
Jdforrester-WMF moved this task from Blocked to Q4 on the VisualEditor board.Jan 31 2015, 2:45 AM

Change 182336 merged by jenkins-bot:
Update "Watch this page" option when necessary

https://gerrit.wikimedia.org/r/182336