Page MenuHomePhabricator
Create Task
Maniphest T78696

Break up ve.ce.Surface.js by functionality
Open, MediumPublic
Actions

Description

ve.ce.Surface is a 130k beast (>4000 lines) - more than twice as long as Converter and Transaction, the next largest files. Working on it will kill your mouse wheel and sanity.

We should try and break it up by functionality, e.g.

  • Key strokes
  • Copy/paste
  • Drag/drop

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (0e82a6db8)Esandersmediawiki/extensions/VisualEditormaster+16 -5
Update VE core submodule to master (bae9101b7)Esandersmediawiki/extensions/VisualEditormaster+144 -116
Move drag/drop handling code to DragDropHandlerEsandersVisualEditor/VisualEditormaster+434 -382
[BREAKING CHANGE] Move selection handling code to SelectionManagerEsandersVisualEditor/VisualEditormaster+424 -320
[BREAKING CHANGE] Move paste handling code to ve.ce.ClipboardHandlerEsandersVisualEditor/VisualEditormaster+3 K -3 K
Introduce key down handlers to separate logic from ce surfaceEsandersVisualEditor/VisualEditormaster+1 K -740
Customize query in gerrit

Related Objects
Search...

Event Timeline

Esanders created this task.Dec 16 2014, 7:09 PM
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added a project: VisualEditor.
Esanders changed Security from none to None.
Esanders subscribed.
Jdforrester-WMF triaged this task as Medium priority.Dec 16 2014, 8:02 PM
Jdforrester-WMF added projects: VisualEditor-ContentEditable, Technical-Debt.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Dec 16 2014, 8:13 PM
Esanders updated the task description. (Show Details)Oct 27 2015, 9:35 AM
Esanders added a comment.Oct 29 2015, 4:11 PM

https://gerrit.wikimedia.org/r/#/c/248911/

gerritbot subscribed.Oct 30 2015, 7:29 PM

Change 248911 merged by jenkins-bot:
Introduce key down handlers to separate logic from ce surface

https://gerrit.wikimedia.org/r/248911

Jdforrester-WMF added a subtask: T116748: Abstract away Selection handling from the surface.Nov 3 2015, 3:28 PM
Jdforrester-WMF closed subtask T118798: Abstract getSelectionRects by selection type as Resolved.Nov 19 2015, 7:01 PM
Danny_B moved this task from Unsorted to Separate concerns on the Technical-Debt board.Apr 21 2016, 8:44 PM
Esanders added a comment.Dec 5 2023, 10:09 PM

After the above patch it dropped to 3,400 lines. Today it is 5,400 (!)

gerritbot added a comment.Oct 10 2024, 1:45 PM

Change #1079286 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Move paste handling code to ve.ce.PasteHandler

https://gerrit.wikimedia.org/r/1079286

gerritbot added a project: Patch-For-Review.Oct 10 2024, 1:45 PM
gerritbot added a comment.Oct 10 2024, 5:25 PM

Change #1079324 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Move selection handling code to SelectionManager

https://gerrit.wikimedia.org/r/1079324

gerritbot added a comment.Oct 16 2024, 2:50 PM

Change #1080733 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Move drag/drop handling code to DragDropHandler

https://gerrit.wikimedia.org/r/1080733

gerritbot added a comment.Oct 18 2024, 7:32 PM

Change #1079286 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Move paste handling code to ve.ce.ClipboardHandler

https://gerrit.wikimedia.org/r/1079286

gerritbot added a comment.Oct 21 2024, 3:03 PM

Change #1081991 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bae9101b7)

https://gerrit.wikimedia.org/r/1081991

gerritbot added a comment.Oct 29 2024, 2:17 PM

Change #1081991 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bae9101b7)

https://gerrit.wikimedia.org/r/1081991

gerritbot added a comment.Oct 29 2024, 2:52 PM

Change #1079324 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Move selection handling code to SelectionManager

https://gerrit.wikimedia.org/r/1079324

gerritbot added a comment.Oct 29 2024, 2:55 PM

Change #1080733 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Move drag/drop handling code to DragDropHandler

https://gerrit.wikimedia.org/r/1080733

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Oct 29 2024, 3:00 PM
gerritbot added a comment.Oct 29 2024, 5:41 PM

Change #1079329 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (69d7ca482)

https://gerrit.wikimedia.org/r/1079329

gerritbot added a comment.Oct 30 2024, 7:07 PM

Change #1079329 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (0e82a6db8)

https://gerrit.wikimedia.org/r/1079329

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits