Page MenuHomePhabricator
Create Task
Maniphest T78701

Hovercards: Mixed languages appearing for "last edit", with non-default wiki language settings, when if Twinkle is activated
Closed, InvalidPublic
Actions

Description

CennoxX writes:

The messages of the last edit on hovercards in the English Wikipedia with German as display language are in mixed languages, something like "Zuletzt bearbeitet 11 months ago" - the first part is German, the second English.
In the German Wikipedia this works fine.

Event Timeline

Quiddity created this task.Dec 16 2014, 8:19 PM
Quiddity raised the priority of this task from to Medium.
Quiddity updated the task description. (Show Details)
Quiddity added a project: Page-Previews.
Quiddity changed Security from none to None.
Quiddity subscribed.
CennoxX subscribed.Dec 17 2014, 10:59 PM
• Prtksxna added a subtask: T69959: The "ago" mechanism is untranslatable due to sentence split.Jan 6 2015, 12:44 PM
• Prtksxna removed a subtask: T69959: The "ago" mechanism is untranslatable due to sentence split.Jan 6 2015, 12:46 PM
• Prtksxna subscribed.Jan 6 2015, 1:22 PM

This seems to be working fine for me on https://en.wikipedia.org/wiki/Main_Page?uselang=de

@CennoxX, could you please add details on how to reproduce this issue?

Screen_Shot_2015-01-06_at_6.48.58_PM.png (258×332 px, 48 KB)

Se4598 subscribed.Jan 6 2015, 1:32 PM

can't reproduce at the moment either

CennoxX added a comment.EditedJan 7 2015, 1:28 PM

I tried to reproduce the bug with another account. It seems like the issue only occures, if Twinkle is activated (in the Gadgets section of the preferences).

• Prtksxna closed this task as Invalid.Jan 7 2015, 2:40 PM
• Prtksxna claimed this task.
In T78701#959276, @CennoxX wrote:

I tried to reproduce the bug with another account. It seems like the issue only occures, if Twinkle is activated (in the Gadgets section of the preferences).

Yup. I can see it too now. I suspect its happening because they are loading their own version of moment.js, the library used to print out strings like 4 days ago. This library has been part of mediawiki core for some time now, so I have raised an issue on its Github project page to switch to that.

Aklapper renamed this task from Hovercards: Mixed languages appearing for "last edit", with non-default wiki language settings to Hovercards: Mixed languages appearing for "last edit", with non-default wiki language settings, when if Twinkle is activated.Jan 7 2015, 3:11 PM
• Prtksxna added a comment.Jan 10 2015, 2:45 AM

This was fixed in Twinkle https://github.com/azatoth/twinkle/commit/84ef0e5a381f30c7d069882e4ef6ddc14c0982cf

CennoxX unsubscribed.Jan 11 2015, 6:47 PM
Quiddity moved this task from Backlog to Done on the Page-Previews board.Apr 14 2015, 8:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits