Page MenuHomePhabricator
Create Task
Maniphest T78710

VisualEditor broken for MobileFrontend
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Broken since 11 December.

As a logged in user with access to VE, attempt to edit any page. See a spinner.

Javascript error shown in Chromium is "TypeError: Illegal invocation TypeError: Illegal invocation "

Details

SubjectRepoBranchLines +/-
Update setupToolbar signature in mobile targetmediawiki/extensions/VisualEditorwmf/1.25wmf13+2 -2
Update setupToolbar signature in mobile targetmediawiki/extensions/VisualEditormaster+2 -2
Fix Ia6bf604c: Update another caller to ve.init.mw.Targetmediawiki/extensions/VisualEditorwmf/1.25wmf13+2 -2
Followup Ia6bf604c, I431a9025: Update way VE target is constructedmediawiki/extensions/MobileFrontendwmf/1.25wmf13+2 -1
Followup Ia6bf604c, I431a9025: Update way VE target is constructedmediawiki/extensions/MobileFrontendmaster+2 -1
Fix Ia6bf604c: Update another caller to ve.init.mw.Targetmediawiki/extensions/VisualEditormaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

• Cmcmahon created this task.Dec 16 2014, 9:52 PM
• Cmcmahon raised the priority of this task from to High.
• Cmcmahon updated the task description. (Show Details)
• Cmcmahon added a project: Web-Team-Backlog.
• Cmcmahon changed Security from none to None.
• Cmcmahon subscribed.
Jdlrobson subscribed.Dec 17 2014, 1:21 AM

Production or beta labs?

Jdlrobson added a project: VisualEditor.Dec 17 2014, 1:21 AM
Krenair added a project: VisualEditor-MediaWiki-Mobile.Dec 17 2014, 1:28 AM
Krenair subscribed.
Jdforrester-WMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Dec 17 2014, 1:40 AM
• Cmcmahon added a comment.Dec 17 2014, 3:07 PM

Beta labs, sorry.

Krenair mentioned this in rEMFRc80d94ed6740: Followup Ia6bf604c, I431a9025: Update way VE target is constructed.Dec 18 2014, 2:37 AM
Krenair mentioned this in rEVEDc5d927552a70: Fix Ia6bf604c: Update another caller to ve.init.mw.Target.
gerritbot added a project: Patch-For-Review.Dec 18 2014, 11:25 AM

Change 180759 had a related patch set uploaded (by Alex Monk):
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/180759

Patch-For-Review

Krenair added a comment.Dec 18 2014, 11:27 AM

(https://gerrit.wikimedia.org/r/180690 happened while Gerrit was down.)

gerritbot added a comment.Dec 18 2014, 11:27 AM

Change 180759 merged by jenkins-bot:
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/180759

Krenair mentioned this in rEVEDf49bbf783ab6: Update setupToolbar signature in mobile target.Dec 18 2014, 11:28 AM
Krenair claimed this task.Dec 18 2014, 11:29 AM

it should now work.

Krenair closed this task as Resolved.Dec 18 2014, 11:31 AM

(Or at least, as well as the desktop version, which just returns a Parsoid error.)

Krenair added a subscriber: hashar.Dec 18 2014, 2:10 PM

(All the many different problems with Parsoid now seem to be fixed, thanks to @hashar)

hashar added a comment.Dec 18 2014, 5:24 PM

Parsoid was stalled to a version from October 28th :-( Thanks to Krenair, Roan and Kartik we get it back to the latest version :-]

Krenair merged a task: T84939: TypeError: Illegal invocation appears while trying to open mobile VE in test2.Dec 18 2014, 10:56 PM
Krenair added a subscriber: Ryasmeen.
gerritbot added a comment.Dec 19 2014, 12:07 AM

Change 180701 merged by jenkins-bot:
Followup Ia6bf604c, I431a9025: Update way VE target is constructed

https://gerrit.wikimedia.org/r/180701

gerritbot added a comment.Dec 19 2014, 12:07 AM

Change 180700 merged by jenkins-bot:
Fix Ia6bf604c: Update another caller to ve.init.mw.Target

https://gerrit.wikimedia.org/r/180700

Jdforrester-WMF mentioned this in rEVED2409f7473565: Fix Ia6bf604c: Update another caller to ve.init.mw.Target.Dec 19 2014, 12:07 AM
Jdforrester-WMF mentioned this in rEMFR346f162264cc: Followup Ia6bf604c, I431a9025: Update way VE target is constructed.
gerritbot added a comment.Dec 19 2014, 12:09 AM

Change 181005 had a related patch set uploaded (by Jforrester):
Update VE and MF for T78710

https://gerrit.wikimedia.org/r/181005

Patch-For-Review

gerritbot added a comment.Dec 19 2014, 12:57 AM

Change 181005 merged by MaxSem:
Update VE and MF for T78710

https://gerrit.wikimedia.org/r/181005

Jdforrester-WMF mentioned this in rMWa19eba0c46fa: Update VE and MF for T78710.Dec 19 2014, 12:57 AM
MaxSem mentioned this in rMW1bb9e96ce529: Merge "Update VE and MF for T78710" into wmf/1.25wmf13.Dec 19 2014, 12:57 AM
gerritbot added a comment.Jan 6 2015, 3:43 AM

Change 182993 had a related patch set uploaded (by Alex Monk):
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/182993

Patch-For-Review

gerritbot added a comment.Jan 6 2015, 4:13 PM

Change 182993 merged by Catrope:
Update setupToolbar signature in mobile target

https://gerrit.wikimedia.org/r/182993

Krenair mentioned this in rEVED987314ce8a4d: Update setupToolbar signature in mobile target.Jan 6 2015, 4:14 PM
Jdforrester-WMF added projects: WMF-deploy-2014-12-17_(1.25wmf13), WMF-deploy-2015-01-07_(1.25wmf14).Jan 7 2015, 4:20 PM
Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 7 2015, 9:17 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM
Etonkovidova subscribed.Jan 9 2015, 12:30 AM

VE works in Mobile betalabs/test2.

Ryasmeen added a comment.Jan 15 2015, 10:59 PM

verified the fix in en.wiki

Ryasmeen added a project: Verified-in-Phase2.Jan 15 2015, 11:00 PM
Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM
Jdforrester-WMF edited a custom field.Feb 2 2015, 8:00 PM
Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM
RandomDSdevel awarded a token.Mar 5 2015, 7:29 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:32 PM
• Phabricator_maintenance moved this task from Incoming to 2014-15 Q2 on the Web-Team-Backlog board.Mar 7 2018, 4:35 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 7 2018, 4:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL