Page MenuHomePhabricator
Create Task
Maniphest T78767

Add Last-Modified to performance logging
Closed, ResolvedPublic
Actions

Description

In order to be able to tell when a thumbnail has been prerendered and is only being pulled from swift to varnish, we need to track this extra response header. Age and Date, which are also needed, are already logged.

Details

SubjectRepoBranchLines +/-
Backport Last-Modified performance logging for Media Viewermediawiki/corewmf/1.25wmf12+1 -1
Log Last-Modified header in performance loggermediawiki/extensions/MultimediaViewerwmf/1.25wmf12+8 -2
Log Last-Modified header in performance loggermediawiki/extensions/MultimediaViewermaster+8 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Gilles created this task.Dec 17 2014, 9:30 AM
• Gilles claimed this task.
• Gilles raised the priority of this task from to Medium.
• Gilles updated the task description. (Show Details)
• Gilles added projects: Multimedia, MediaViewer, Analytics.
• Gilles changed Security from none to None.
• Gilles mentioned this in T78205: Create MediaViewer image varnish hit/miss ratio dashboard.
• Gilles moved this task from Untriaged to Next up on the Multimedia board.
• Gilles added subscribers: • Gilles, Tgr.
• Gilles added a comment.Dec 17 2014, 9:34 AM

Actually, as @Tgr pointed out, Varnish's X-Timestamp is the same as Last-Modified, and we're already logging that. Assuming that the clocks of varnish servers and eventlogging http (sql?) servers are in sync, "Date" should be the same as the "timestamp" column of the EL table. I'll run some SQL queries to see if that all holds true.

• Gilles added a comment.Dec 17 2014, 9:45 AM

Actually timestamp != Date for one very obvious reason: the EL event will only be recorded after the image load, and will depend on latency. So we do need to log "Date". We don't really need Last-Modified since it should be identical to X-Timestamp, but I'll add it just in case.

• Gilles added a comment.Dec 17 2014, 10:15 AM

Saving this for later: P163

• Gilles added a comment.Dec 17 2014, 10:26 AM

Ah, it turns out that the "timestamp" column IS the Date header. So we only need Last-Modified.

• Gilles renamed this task from Add Last-Modified and Date to performance logging to Add Last-Modified to performance logging.Dec 17 2014, 10:30 AM
• Gilles updated the task description. (Show Details)
gerritbot added a project: Patch-For-Review.Dec 17 2014, 10:31 AM

Change 180433 had a related patch set uploaded (by Gilles):
Log Last-Modified header in performance logger

https://gerrit.wikimedia.org/r/180433

Patch-For-Review

• Gilles moved this task from Next up to Needs code review on the Multimedia board.Dec 17 2014, 10:32 AM
Tgr added a comment.Dec 17 2014, 6:47 PM
In T78767#852888, @Gilles wrote:

Ah, it turns out that the "timestamp" column IS the Date header. So we only need Last-Modified.

I think timestamp is added by Varnish when it receives the EL request, so it would equal the Date header of the EL request, not the Date header of the thumbnail request that's being logged?

Tgr added a comment.Dec 17 2014, 6:49 PM

Oh yeah we have a manual timestamp field, I remember now.

Tgr added a comment.Dec 17 2014, 6:53 PM

Last-Modified is a simple response header so there should not be any CORS issues with this.

Tgr moved this task from Needs code review to Ready for testing on the Multimedia board.Dec 17 2014, 6:54 PM
gerritbot added a comment.Dec 17 2014, 7:26 PM

Change 180433 merged by jenkins-bot:
Log Last-Modified header in performance logger

https://gerrit.wikimedia.org/r/180433

• Gilles mentioned this in rEMMVb3e281237c1d: Log Last-Modified header in performance logger.Dec 17 2014, 7:27 PM
• Gilles moved this task from Ready for testing to Needs backport on the Multimedia board.Dec 18 2014, 8:52 AM
gerritbot added a comment.Dec 18 2014, 9:35 AM

Change 180742 had a related patch set uploaded (by Gilles):
Log Last-Modified header in performance logger

https://gerrit.wikimedia.org/r/180742

Patch-For-Review

gerritbot added a comment.Dec 18 2014, 9:37 AM

Change 180742 merged by jenkins-bot:
Log Last-Modified header in performance logger

https://gerrit.wikimedia.org/r/180742

• Gilles mentioned this in rEMMV628dd8a87854: Log Last-Modified header in performance logger.Dec 18 2014, 9:37 AM
gerritbot added a comment.Dec 18 2014, 9:41 AM

Change 180743 had a related patch set uploaded (by Gilles):
Backport Last-Modified performance logging for Media Viewer

https://gerrit.wikimedia.org/r/180743

Patch-For-Review

gerritbot added a comment.Dec 18 2014, 4:09 PM

Change 180743 merged by jenkins-bot:
Backport Last-Modified performance logging for Media Viewer

https://gerrit.wikimedia.org/r/180743

• Gilles mentioned this in rMW0813fbddddfb: Backport Last-Modified performance logging for Media Viewer.Dec 18 2014, 4:10 PM
• Gilles moved this task from Needs backport to Done on the Multimedia board.Dec 18 2014, 4:22 PM
• Gilles moved this task from Done to Doing on the Multimedia board.
• Gilles moved this task from Doing to Done on the Multimedia board.Jan 7 2015, 4:43 PM
• Gilles closed this task as Resolved.Jan 8 2015, 5:32 AM
• Gilles closed subtask T84852: Update network performance schema queries as Resolved.
Diffusion mentioned this in rMEXT63e47d0af961: Updated mediawiki/extensions Project: mediawiki/extensions/MultimediaViewer….Mar 11 2015, 6:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL