Page MenuHomePhabricator

Add ability to add from PMID or PMCID to distinguish.js
Closed, ResolvedPublic

Description

Currently distinguish.js looks for a DOI in the "search" field from GET requests to the /api endpoint, and if there's no DOI, assumes it's a URL. If DOI, calls requestFromDOI, if URL, calls requestFromURL.

However, requestFromPubMedID was recently added to requests.js, so this needs to be added as an option in the distinguish.js file. Use regex to determine if something is a PMID or PCMID, and call the requestFromPubMedID method. Continue to use URL as the default case.

Event Timeline

Mvolz raised the priority of this task from to Needs Triage.
Mvolz updated the task description. (Show Details)
Mvolz added a project: Citoid.
Mvolz changed Security from none to None.
Mvolz added a subscriber: Mvolz.
Mvolz renamed this task from Add ability to add from PMID or PMCID from distinguish.js to Add ability to add from PMID or PMCID to distinguish.js.Dec 17 2014, 10:57 AM

@Sn1per: As you added the project Google-Code-in-2014, is there already a task for it? URL welcome.

Change 182752 had a related patch set uploaded (by Sn1per):
Detect and request PMID/PCMID info

https://gerrit.wikimedia.org/r/182752

Patch-For-Review

Change 182752 merged by Mvolz:
Detect and request PMID/PCMID info

https://gerrit.wikimedia.org/r/182752