#related use wrong CSS classes on Monobook & Modern
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Andyrom75
	Dec 18 2014, 8:02 AM

Description

#related works perfectly with Vector skin, but with Monobook & Modern use the wrong classes, so the layout is bad.

Let's take for example this page: https://it.wikivoyage.org/wiki/Clusane

The class of "#p-relatedarticles" is "portal" instead of "portlet"
The class of "#p-relatedarticles div" is "body" instead of "pBody"
Can it be fixed?

Related Objects

Mentioned Here: T165991: Remove sidebar code from RelatedArticles extension

Event Timeline

Andyrom75 created this task.Dec 18 2014, 8:02 AM

Andyrom75 raised the priority of this task from to Medium.

Andyrom75 updated the task description. (Show Details)

Andyrom75 added a project: RelatedArticles.

Andyrom75 changed Security from none to None.

Andyrom75 subscribed.

Aklapper lowered the priority of this task from Medium to Lowest.Dec 19 2014, 3:09 PM

Just to be more specific, these are the changes that need to be implemented:

(mw.config.get('skin') == 'vector' ? 'portal' : 'portlet') in place of portal
(mw.config.get('skin') == "vector" ? "body" : "pBody") in place of body

Is there a reason why Vector and Monobook use different names for the portlet/portal and pBody/body classes? It looks like the classes have the same purpose, so different skins should be able to use the same class names.

Jdlrobson added projects: MonoBook, Modern.Feb 5 2016, 12:11 AM

MBinder_WMF added a project: Web-Team-Backlog.Apr 27 2016, 4:28 PM

MBinder_WMF moved this task from Incoming to Triaged but Future on the Web-Team-Backlog board.Jul 4 2016, 7:23 PM

Probably will be impacted by T165991

This code is scheduled for removal (see T165991) and currently not deployed on any production wikis.

#related use wrong CSS classes on Monobook & ModernClosed, DeclinedPublicActions

Description

Related Objects

Event Timeline

#related use wrong CSS classes on Monobook & Modern
Closed, DeclinedPublic
Actions