[Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Load VE editor with http://en.m.wikipedia.beta.wmflabs.org/wiki/Headings#/editor/0
Switch to wikitext editor

Switch fails and editor dies with

Regex
All
Errors
Warnings
Info
Logs
Debug
.
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141217T…:150 Exception thrown by user callback
load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=minerva&version=20141217T…:150 TypeError: Cannot read property '0' of null
TypeError: Cannot read property '0' of null {stack: (...), message: "Cannot read property '0' of null"}
2
VM857:9 Uncaught TypeError: Cannot read property '0' of null

Details

	Subject	Repo	Branch	Lines +/-
	Remove this.$element on destroy but don't nullify	VisualEditor/VisualEditor	wmf/1.25wmf13	+1 -4
	Remove this.$element on destroy but don't nullify	VisualEditor/VisualEditor	master	+1 -4

Customize query in gerrit

Related Objects

Mentioned In: rGVED7bba15fba905: Remove this.$element on destroy but don't nullify
Mentioned Here: T85480: in MobileFrontend, invoking the editor is incorrect and switching from VisualEditor to wikitext editor does nothing
T85897: Mobile VisualEditor won't load (this.getSurface(...) is undefined)

Event Timeline

Jdlrobson created this task.Dec 18 2014, 5:49 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog.

Jdlrobson changed Security from none to None.

Jdlrobson subscribed.

Does the MobileFrontend code for switching back to wikitext attempt to use ve.instances[0] by any chance? If so, try to replace that with target.getSurface(), where target is the instance of ve.init.mw.MobileViewTarget that is created by MF.

Jdforrester-WMF added a project: VisualEditor-MediaWiki-Mobile.Dec 18 2014, 6:25 PM

Jdforrester-WMF subscribed.

Restricted Application added a project: VisualEditor. · View Herald TranscriptDec 18 2014, 6:25 PM

• Cmcmahon merged a task: T84898: Editing breaks and edit button does nothing after switching from VE to wikitext editor.Dec 18 2014, 6:35 PM

• Cmcmahon subscribed.

Jdlrobson moved this task from Incoming to Old Unorganized Resolved Tasks on the Web-Team-Backlog board.Dec 18 2014, 6:36 PM

[19:37]	edsanders	RoanKattouw, not ve.instances[0]
[19:38]	edsanders	it's in target.unbindHandlers
[19:39]	edsanders	RoanKattouw, tries to call getElementDocument after this.$element has been nulled
[19:39]	edsanders	not sure why this.$element would ever be null though
[19:40]	edsanders	oh, because we set it to null in destroy
[19:40]	edsanders	that seems like a left over from when we generated this.$element

Change 180852 had a related patch set uploaded (by Esanders):
Remove this.$element on destroy but don't nullify

https://gerrit.wikimedia.org/r/180852

Patch-For-Review

Change 180852 merged by jenkins-bot:
Remove this.$element on destroy but don't nullify

https://gerrit.wikimedia.org/r/180852

Jdforrester-WMF renamed this task from Cannot switch from VE to wikitext editor to [Regression pre-wmf14] Cannot switch from VE to wikitext editor.Dec 18 2014, 8:24 PM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF triaged this task as High priority.

Jdforrester-WMF moved this task from To Triage to Blocked on the VisualEditor board.

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.

Jdforrester-WMF renamed this task from [Regression pre-wmf14] Cannot switch from VE to wikitext editor to [Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web.Dec 18 2014, 8:26 PM

Jdforrester-WMF moved this task from FY 18-19 Q3/Q4 to External and Administrivia on the VisualEditor board.

Jdlrobson closed this task as Resolved.Dec 19 2014, 12:30 AM

Jdforrester-WMF added a project: WMF-deploy-2015-01-07_(1.25wmf14).Dec 19 2014, 12:30 AM

Is it resolved ? I am still getting the following errors in Betalabs:
TypeError: obj is null
Uncaught TypeError: Cannot read property '0' of null

And in test2:
TypeError: this.getSurface(...) is undefined
Uncaught TypeError: Cannot read property 'triggerListener' of undefined

re-opening, this is still a problem

This is fixed but VE hasn't been redeployed yet.

Verified the fix in Betalabs

Krenair merged a task: T85348: Uncaught TypeError when strating mobile VisualEditor.Dec 26 2014, 8:33 PM

Krenair added a subscriber: Florian.

Change 181901 had a related patch set uploaded (by Alex Monk):
Remove this.$element on destroy but don't nullify

https://gerrit.wikimedia.org/r/181901

Patch-For-Review

Change 181901 merged by jenkins-bot:
Remove this.$element on destroy but don't nullify

https://gerrit.wikimedia.org/r/181901

Checked in betalabs - the issue is fixed. However, https://phabricator.wikimedia.org/T85480 - cannot switch from VE to 'Edit source' and back to VE.

(That's T85480. That fix got deployed too, but it seems there's a third bug, T85897.)

Jdforrester-WMF moved this task from External and Administrivia to FY 18-19 Q3/Q4 on the VisualEditor board.Jan 7 2015, 9:17 PM

Jdforrester-WMF removed a project: Patch-For-Review.Jan 7 2015, 9:25 PM

Etonkovidova added a project: Verified-in-Phase0.Jan 9 2015, 12:33 AM

Verified in en.wiki

Ryasmeen added a project: Verified-in-Phase2.Jan 15 2015, 10:56 PM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM

Jdforrester-WMF edited a custom field.Jan 23 2015, 11:54 PM

Jdforrester-WMF moved this task from Nominated to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM

Esanders mentioned this in rGVED7bba15fba905: Remove this.$element on destroy but don't nullify.Mar 3 2015, 7:37 PM

• Phabricator_maintenance moved this task from Old Unorganized Resolved Tasks to 2014-15 Q2 on the Web-Team-Backlog board.Mar 7 2018, 4:33 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 7 2018, 4:33 AM

[Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile WebClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

[Regression pre-wmf14] Cannot switch from VE to wikitext editor in Mobile Web
Closed, ResolvedPublic1 Estimated Story Points
Actions