Page MenuHomePhabricator
Create Task
Maniphest T84954

O1. Flow new-header API result different from commit message
Closed, ResolvedPublic
Actions

Description

The commit message for https://gerrit.wikimedia.org/r/#/c/180588/ says

For consistency everything is now in the form of: post-revision-id, topic-revision-id, header-revision-id, etc.

But I edited a Flow board header and the API response contained flow.edit-header.committed.header.revision-id. The key isn't prefixed with "header-". It's not ambiguous as it's in a different key in the response than e.g. flow.newtopic.committed; which is the intended design? Flow/Architecture/API documents the API.

Details

SubjectRepoBranchLines +/-
new-header api result is inconsistentmediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Spage created this task.Dec 19 2014, 12:47 AM
• Spage assigned this task to EBernhardson.
• Spage raised the priority of this task from to Medium.
• Spage updated the task description. (Show Details)
• Spage added projects: Collaboration-Team-Triage, StructuredDiscussions.
• Spage changed Security from none to None.
• Spage subscribed.
• Spage updated the task description. (Show Details)Dec 19 2014, 1:42 AM
• Spage moved this task from Untriaged to Ready for next sprint on the Collaboration-Team-Triage board.Dec 19 2014, 3:40 AM
• Spage renamed this task from Flow new-header API result different from commit message to Flow new-header API result different from commit message (1).Jan 9 2015, 7:07 PM
• Spage renamed this task from Flow new-header API result different from commit message (1) to (1) Flow new-header API result different from commit message.Jan 9 2015, 7:13 PM
• DannyH renamed this task from (1) Flow new-header API result different from commit message to [1] Flow new-header API result different from commit message.Jan 12 2015, 6:16 PM
• DannyH moved this task from Ready for next sprint to Sprint O (ends Jan 27) on the Collaboration-Team-Triage board.Jan 12 2015, 8:25 PM
• DannyH renamed this task from [1] Flow new-header API result different from commit message to [1] O1. Flow new-header API result different from commit message.Jan 12 2015, 9:23 PM
EBernhardson moved this task from Sprint O (ends Jan 27) to In Development on the Collaboration-Team-Triage board.Jan 14 2015, 7:46 PM
gerritbot added a project: Patch-For-Review.Jan 14 2015, 7:49 PM
gerritbot subscribed.

Change 184978 had a related patch set uploaded (by EBernhardson):
new-header api result is inconsistent

https://gerrit.wikimedia.org/r/184978

Patch-For-Review

EBernhardson moved this task from In Development to Code Review on the Collaboration-Team-Triage board.Jan 14 2015, 7:49 PM
• Mattflaschen-WMF added a project: Collaboration-Team-Sprint-P-2015-02-11/q3.Jan 28 2015, 7:22 PM
• Mattflaschen-WMF subscribed.
matthiasmullie moved this task from Sprint P - ends Feb 11 to Code Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 28 2015, 7:28 PM
• Mattflaschen-WMF removed a project: Collaboration-Team-Triage.Jan 28 2015, 7:29 PM
matthiasmullie moved this task from Code Review to Product Review on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Jan 30 2015, 12:22 AM
gerritbot added a comment.Jan 30 2015, 2:06 AM

Change 184978 merged by Matthias Mullie:
new-header api result is inconsistent

https://gerrit.wikimedia.org/r/184978

matthiasmullie mentioned this in rEFLW4abd0a45e4a0: new-header api result is inconsistent.Jan 30 2015, 2:06 AM
• DannyH renamed this task from [1] O1. Flow new-header API result different from commit message to O1. Flow new-header API result different from commit message.Feb 3 2015, 11:55 PM
• DannyH closed this task as Resolved.
• DannyH subscribed.
• DannyH moved this task from Product Review to Done on the Collaboration-Team-Sprint-P-2015-02-11/q3 board.Feb 3 2015, 11:58 PM
matthiasmullie mentioned this in rMEXTc61cbe285fcc: Updated mediawiki/extensions Project: mediawiki/extensions/Flow….Mar 11 2015, 6:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL